Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1047083002: Update widget with latext fix from source_span (Closed)

Created:
5 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 8 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M lib/runtime/messages_widget.js View 4 chunks +12 lines, -10 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/server_mode/html_input.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
I haven't published the fix in source_span yet, but I soon as I do, I ...
5 years, 8 months ago (2015-03-31 01:12:57 UTC) #2
Jacob
lgtm
5 years, 8 months ago (2015-03-31 06:07:37 UTC) #3
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-03-31 20:11:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c2eb3d2a35a2bb87e2f73046d2877259898c1d72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698