Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1046963002: Remove invalid assertion (Closed)

Created:
5 years, 8 months ago by mike3
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove invalid assertion The removed assertion consistently passes not because the invoked `close` method internally throws a `TypeError` but because the `close` method does not exist. The ES6 specification does not define a `close` method on the GeneratorPrototype, so this test is a tautology. BUG=None LOG=N R=arv Committed: https://crrev.com/30ea62688657f4d8c69b54b0fbe393815373e341 Cr-Commit-Position: refs/heads/master@{#27567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M test/mjsunit/es6/generators-objects.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mike3
Could you please take a look?
5 years, 8 months ago (2015-03-31 21:58:22 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 8 months ago (2015-03-31 22:03:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1046963002/1
5 years, 8 months ago (2015-03-31 23:15:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1673)
5 years, 8 months ago (2015-03-31 23:27:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1046963002/1
5 years, 8 months ago (2015-04-01 15:20:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 15:22:14 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 15:22:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30ea62688657f4d8c69b54b0fbe393815373e341
Cr-Commit-Position: refs/heads/master@{#27567}

Powered by Google App Engine
This is Rietveld 408576698