Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: public/web/WebFrameClient.h

Issue 1046953003: Add the WebHistoryCommitType to didFailProvisionalLoad, part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebFrameClient.h
diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h
index 187296cdf0740581fb3f88b97bb7af3f4aca0167..1ebd2f245e766ab255b4f24c4a4486c1b7f7c936 100644
--- a/public/web/WebFrameClient.h
+++ b/public/web/WebFrameClient.h
@@ -263,8 +263,9 @@ public:
// The provisional load was redirected via a HTTP 3xx response.
virtual void didReceiveServerRedirectForProvisionalLoad(WebLocalFrame*) { }
- // The provisional load failed.
- virtual void didFailProvisionalLoad(WebLocalFrame*, const WebURLError&) { }
+ // The provisional load failed. The WebHistoryCommitType is the commit type
+ // that would have been used had the load succeeded.
+ virtual void didFailProvisionalLoad(WebLocalFrame*, const WebURLError&, WebHistoryCommitType) { }
// The provisional datasource is now committed. The first part of the
// response body has been received, and the encoding of the response
@@ -294,8 +295,10 @@ public:
// The 'load' event was dispatched.
virtual void didHandleOnloadEvents(WebLocalFrame*) { }
- // The frame's document or one of its subresources failed to load.
- virtual void didFailLoad(WebLocalFrame*, const WebURLError&) { }
+ // The frame's document or one of its subresources failed to load. The
+ // WebHistoryCommitType is the commit type that would have been used had the
+ // load succeeded.
+ virtual void didFailLoad(WebLocalFrame*, const WebURLError&, WebHistoryCommitType) { }
// The frame's document and all of its subresources succeeded to load.
virtual void didFinishLoad(WebLocalFrame*) { }
« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698