Source/web/FrameLoaderClientImpl.h - Issue 1046953003: Add the WebHistoryCommitType to didFailProvisionalLoad, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 1046953003: Add the WebHistoryCommitType to didFailProvisionalLoad, part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.h

diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h

index 3de2e8d1ff035a2ca318b801173cf98397c8cf51..44ed27cdfd465e1c553eb88b90d2c75580f27bf0 100644

--- a/Source/web/FrameLoaderClientImpl.h

+++ b/Source/web/FrameLoaderClientImpl.h

@@ -90,8 +90,8 @@ public:

virtual void dispatchDidReceiveTitle(const String&) override;

virtual void dispatchDidChangeIcons(IconType) override;

virtual void dispatchDidCommitLoad(HistoryItem*, HistoryCommitType) override;

- virtual void dispatchDidFailProvisionalLoad(const ResourceError&) override;

- virtual void dispatchDidFailLoad(const ResourceError&) override;

+ virtual void dispatchDidFailProvisionalLoad(const ResourceError&, HistoryCommitType) override;

+ virtual void dispatchDidFailLoad(const ResourceError&, HistoryCommitType) override;

virtual void dispatchDidFinishDocumentLoad() override;

virtual void dispatchDidFinishLoad() override;

virtual void dispatchDidFirstVisuallyNonEmptyLayout() override;

« no previous file with comments | « Source/core/loader/FrameLoaderClient.h ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »