Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2335)

Unified Diff: content/renderer/render_frame_proxy.cc

Issue 1046933005: Refactor postMessage for out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Charlie's nits Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_proxy.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_proxy.cc
diff --git a/content/renderer/render_frame_proxy.cc b/content/renderer/render_frame_proxy.cc
index ae6d699ae739783c76a70f4dcb05fcd246c45949..a8b79d0f1c9137635fa2578ca442fdd3c652cda8 100644
--- a/content/renderer/render_frame_proxy.cc
+++ b/content/renderer/render_frame_proxy.cc
@@ -318,7 +318,7 @@ void RenderFrameProxy::postMessageEvent(
blink::WebDOMMessageEvent event) {
DCHECK(!web_frame_ || web_frame_ == target_frame);
- ViewMsg_PostMessage_Params params;
+ FrameMsg_PostMessage_Params params;
params.is_data_raw_string = false;
params.data = event.data().toString();
params.source_origin = event.origin();
@@ -333,13 +333,14 @@ void RenderFrameProxy::postMessageEvent(
// frame in the target process.
params.source_routing_id = MSG_ROUTING_NONE;
if (source_frame) {
- RenderViewImpl* source_view =
- RenderViewImpl::FromWebView(source_frame->view());
- if (source_view)
- params.source_routing_id = source_view->routing_id();
+ RenderFrameImpl* source_render_frame =
+ RenderFrameImpl::FromWebFrame(source_frame);
+ if (source_render_frame)
+ params.source_routing_id = source_render_frame->GetRoutingID();
}
+ params.source_view_routing_id = MSG_ROUTING_NONE;
- Send(new ViewHostMsg_RouteMessageEvent(render_view_->GetRoutingID(), params));
+ Send(new FrameHostMsg_RouteMessageEvent(routing_id_, params));
}
void RenderFrameProxy::initializeChildFrame(
« no previous file with comments | « content/renderer/render_frame_proxy.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698