Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1046933004: gn: add TextMate syntax for Sublime Text 2/3 (Closed)

Created:
5 years, 8 months ago by keybuk
Modified:
5 years, 8 months ago
Reviewers:
tfarina, brettw, scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: add TextMate syntax for Sublime Text 2/3 Install by placing in your <data_path>/Packages/User directory. Committed: https://crrev.com/53d42c09f2051e1d294b114e28d63620ce06a429 Cr-Commit-Position: refs/heads/master@{#326329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
A tools/gn/misc/GN.tmLanguage View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
keybuk
5 years, 8 months ago (2015-03-30 17:45:20 UTC) #2
scottmg
I don't have ST installed, but rs lgtm.
5 years, 8 months ago (2015-03-30 18:12:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1046933004/1
5 years, 8 months ago (2015-04-22 17:00:50 UTC) #5
tfarina
Can you add this under tools/gn/misc/sublime? Similarly we have vim and emacs directories there.
5 years, 8 months ago (2015-04-22 17:05:35 UTC) #7
keybuk
On 2015/04/22 17:05:35, tfarina wrote: > Can you add this under tools/gn/misc/sublime? Similarly we have ...
5 years, 8 months ago (2015-04-22 17:09:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 17:30:19 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 17:31:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53d42c09f2051e1d294b114e28d63620ce06a429
Cr-Commit-Position: refs/heads/master@{#326329}

Powered by Google App Engine
This is Rietveld 408576698