third_party/google_input_tools/src/chrome/os/inputview/elements/content/material/spacekey.js - Issue 1046933003: Updates google-input-tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/google_input_tools/src/chrome/os/inputview/elements/content/material/spacekey.js

Issue 1046933003: Updates google-input-tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/google_input_tools/src/chrome/os/inputview/elements/content/keysetview.js ('k') | third_party/google_input_tools/src/chrome/os/inputview/elements/content/menuview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/google_input_tools/src/chrome/os/inputview/elements/content/material/spacekey.js

diff --git a/third_party/google_input_tools/src/chrome/os/inputview/elements/content/material/spacekey.js b/third_party/google_input_tools/src/chrome/os/inputview/elements/content/material/spacekey.js

index 479db6b036d51eabf6b15531223aeb6eb7d1ed77..6abb137ca085af31eed913931039be6d9468cd35 100644

--- a/third_party/google_input_tools/src/chrome/os/inputview/elements/content/material/spacekey.js

+++ b/third_party/google_input_tools/src/chrome/os/inputview/elements/content/material/spacekey.js

@@ -147,12 +147,13 @@ SpaceKey.prototype.getCharacter = function() {

* @param {boolean} visible True to set title visible.

SpaceKey.prototype.updateTitle = function(title, visible) {

- if (this.textElem) {

- this.text = title;

- goog.dom.setTextContent(this.textElem, visible ? title : '');

- goog.dom.classlist.add(this.textElem,

- i18n.input.chrome.inputview.Css.TITLE);

+ if (this.iconCss_) {

+ return;

}

+ this.text = title;

+ goog.dom.setTextContent(this.wrapper_, visible ? title : '');

+ goog.dom.classlist.add(this.wrapper_,

+ i18n.input.chrome.inputview.Css.TITLE);

};