Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 104683002: Add WebRTC master to the TestResultsServer app (Closed)

Created:
7 years ago by kjellander_chromium
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add WebRTC master to the TestResultsServer app BUG=325726 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Tools/TestResultServer/handlers/buildershandler.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
Adding WebRTC standalone master as discussed offline.
7 years ago (2013-12-04 14:37:41 UTC) #1
ojan
lgtm On Wed, Dec 4, 2013 at 6:37 AM, <kjellander@chromium.org> wrote: > Reviewers: ojan, > ...
7 years ago (2013-12-04 17:37:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/104683002/1
6 years, 1 month ago (2014-11-05 18:47:40 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Tools/TestResultServer/handlers/buildershandler.py: While running patch -p1 --forward --force --no-backup-if-mismatch; A Tools/TestResultServer ...
6 years, 1 month ago (2014-11-05 18:47:46 UTC) #6
kjellander_chromium
6 years, 1 month ago (2014-11-05 22:29:43 UTC) #7
On 2014/11/05 18:47:46, I haz the power (commit-bot) wrote:
> Failed to apply patch for Tools/TestResultServer/handlers/buildershandler.py:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   A         Tools/TestResultServer
>   Created missing directory Tools/TestResultServer.
>   A         Tools/TestResultServer/handlers
>   Created missing directory Tools/TestResultServer/handlers.
>   can't find file to patch at input line 6
>   Perhaps you used the wrong -p or --strip option?
>   The text leading up to this was:
>   --------------------------
>   |Index: Tools/TestResultServer/handlers/buildershandler.py
>   |diff --git a/Tools/TestResultServer/handlers/buildershandler.py
> b/Tools/TestResultServer/handlers/buildershandler.py
>   |index
>
f67866c17b5619674ca1ac8f24ca6985cd53765f..ec74bff24b3b6f66bf12e42f5ab3efdd65fad908
> 100644
>   |--- a/Tools/TestResultServer/handlers/buildershandler.py
>   |+++ b/Tools/TestResultServer/handlers/buildershandler.py
>   --------------------------
>   No file to patch.  Skipping patch.
>   1 out of 1 hunk ignored
> 
> Patch:       Tools/TestResultServer/handlers/buildershandler.py
> Index: Tools/TestResultServer/handlers/buildershandler.py
> diff --git a/Tools/TestResultServer/handlers/buildershandler.py
> b/Tools/TestResultServer/handlers/buildershandler.py
> index
>
f67866c17b5619674ca1ac8f24ca6985cd53765f..ec74bff24b3b6f66bf12e42f5ab3efdd65fad908
> 100644
> --- a/Tools/TestResultServer/handlers/buildershandler.py
> +++ b/Tools/TestResultServer/handlers/buildershandler.py
> @@ -47,6 +47,7 @@ MASTERS = [
>      {'name': 'ChromiumWebkit', 'url':
> 'http://build.chromium.org/p/chromium.webkit', 'groups': ['@ToT Chromium',
'@ToT
> Blink']},
>      {'name': 'ChromiumFYI', 'url':
'http://build.chromium.org/p/chromium.fyi',
> 'groups': ['@ToT Chromium FYI']},
>      {'name': 'V8', 'url': 'http://build.chromium.org/p/client.v8', 'groups':
> ['@ToT V8']},
> +    {'name': 'WebRTC', 'url': 'http://build.chromium.org/p/client.webrtc',
> 'groups': ['@ToT WebRTC']},
>  ]

Abandoning this CL for a new one making the change in
infra/appengine_apps/test_results/appengine_module/test_results/handlers/master_config.py
instead.

Powered by Google App Engine
This is Rietveld 408576698