Pepper: Send dev/canary channel status to plugins.

Pepper: Send dev/canary channel status to plugins.

As part of supporting "dev channel" methods in Pepper APIs, the plugin needs to
know whether or not it's running in a channel that supports those methods.

This patch plumbs that information through LoadPlugin so it's available by the
time get_interface<>() would ever be called.

TBR=piman
BUG=325403
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240398

[bbudge, 2013-12-11 18:32:18]

Are you planning to plumb this bit down into the untrusted NaCl plugin?

https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:2668: return channel >=
chrome::VersionInfo::CHANNEL_DEV;
I think the direction of the inequality should be reversed. It looks like BETA
and STABLE are higher.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/chro...

[teravest, 2013-12-11 20:17:45]

On Wed, Dec 11, 2013 at 11:32 AM,  <bbudge@chromium.org> wrote:
> Are you planning to plumb this bit down into the untrusted NaCl plugin?

What do you mean? I had planned to add a check inside
GetInterfaceForPPB(). I expect that to run in untrusted plugins.

>
>
>
https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
> File chrome/browser/chrome_content_browser_client.cc (right):
>
>
https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
> chrome/browser/chrome_content_browser_client.cc:2668: return channel >=
> chrome::VersionInfo::CHANNEL_DEV;
> I think the direction of the inequality should be reversed. It looks
> like BETA and STABLE are higher.

Thanks, fixed.

>
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/chro...
>
> https://codereview.chromium.org/104673003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[bbudge, 2013-12-11 20:29:09]

On 2013/12/11 20:17:45, teravest wrote:
> On Wed, Dec 11, 2013 at 11:32 AM,  <mailto:bbudge@chromium.org> wrote:
> > Are you planning to plumb this bit down into the untrusted NaCl plugin?
> 
> What do you mean? I had planned to add a check inside
> GetInterfaceForPPB(). I expect that to run in untrusted plugins.
> 
> >
> >
> >
>
https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
> > File chrome/browser/chrome_content_browser_client.cc (right):
> >
> >
>
https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
> > chrome/browser/chrome_content_browser_client.cc:2668: return channel >=
> > chrome::VersionInfo::CHANNEL_DEV;
> > I think the direction of the inequality should be reversed. It looks
> > like BETA and STABLE are higher.
> 
> Thanks, fixed.
> 
> >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/chro...
> >
> > https://codereview.chromium.org/104673003/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I'm wondering how SetSupportsDevChannel will get called in the NaCl case. We
don't run ppapi_thread.cc in NaCl.

[teravest1, 2013-12-11 20:32:38]

On Wed, Dec 11, 2013 at 1:29 PM,  <bbudge@chromium.org> wrote:
> On 2013/12/11 20:17:45, teravest wrote:
>
>> On Wed, Dec 11, 2013 at 11:32 AM,  <mailto:bbudge@chromium.org> wrote:
>> > Are you planning to plumb this bit down into the untrusted NaCl plugin?
>
>
>> What do you mean? I had planned to add a check inside
>> GetInterfaceForPPB(). I expect that to run in untrusted plugins.
>
>
>> >
>> >
>> >
>
>
>
https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
>>
>> > File chrome/browser/chrome_content_browser_client.cc (right):
>> >
>> >
>
>
>
https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
>>
>> > chrome/browser/chrome_content_browser_client.cc:2668: return channel >=
>> > chrome::VersionInfo::CHANNEL_DEV;
>> > I think the direction of the inequality should be reversed. It looks
>> > like BETA and STABLE are higher.
>
>
>> Thanks, fixed.
>
>
>> >
>> >
>
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/chro...
>>
>> >
>> > https://codereview.chromium.org/104673003/
>
>
>> To unsubscribe from this group and stop receiving emails from it, send an
>
> email
>>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>
>
> I'm wondering how SetSupportsDevChannel will get called in the NaCl case. We
> don't run ppapi_thread.cc in NaCl.

Ah, okay.
I'll plumb it through near here:
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/proxy/plugin...

Thanks for catching that.

>
> https://codereview.chromium.org/104673003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest1, 2013-12-11 21:10:47]

Can you take another look? Thanks.

On Wed, Dec 11, 2013 at 1:32 PM, Justin TerAvest <teravest@google.com> wrote:
> On Wed, Dec 11, 2013 at 1:29 PM,  <bbudge@chromium.org> wrote:
>> On 2013/12/11 20:17:45, teravest wrote:
>>
>>> On Wed, Dec 11, 2013 at 11:32 AM,  <mailto:bbudge@chromium.org> wrote:
>>> > Are you planning to plumb this bit down into the untrusted NaCl plugin?
>>
>>
>>> What do you mean? I had planned to add a check inside
>>> GetInterfaceForPPB(). I expect that to run in untrusted plugins.
>>
>>
>>> >
>>> >
>>> >
>>
>>
>>
https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
>>>
>>> > File chrome/browser/chrome_content_browser_client.cc (right):
>>> >
>>> >
>>
>>
>>
https://codereview.chromium.org/104673003/diff/1/chrome/browser/chrome_conten...
>>>
>>> > chrome/browser/chrome_content_browser_client.cc:2668: return channel >=
>>> > chrome::VersionInfo::CHANNEL_DEV;
>>> > I think the direction of the inequality should be reversed. It looks
>>> > like BETA and STABLE are higher.
>>
>>
>>> Thanks, fixed.
>>
>>
>>> >
>>> >
>>
>>
>>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/chro...
>>>
>>> >
>>> > https://codereview.chromium.org/104673003/
>>
>>
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>
>> email
>>>
>>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>>
>> I'm wondering how SetSupportsDevChannel will get called in the NaCl case. We
>> don't run ppapi_thread.cc in NaCl.
>
> Ah, okay.
> I'll plumb it through near here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/proxy/plugin...
>
> Thanks for catching that.
>
>>
>> https://codereview.chromium.org/104673003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[bbudge, 2013-12-11 21:20:36]

LGTM w/comments.

https://codereview.chromium.org/104673003/diff/40001/ppapi/shared_impl/ppapi_...
File ppapi/shared_impl/ppapi_nacl_channel_args.h (right):

https://codereview.chromium.org/104673003/diff/40001/ppapi/shared_impl/ppapi_...
ppapi/shared_impl/ppapi_nacl_channel_args.h:22: bool supports_dev_channel;
This and 'off_the_record' don't seem to be initialized properly in the .cc file.

[teravest, 2013-12-11 21:25:43]

On Wed, Dec 11, 2013 at 2:20 PM,  <bbudge@chromium.org> wrote:
> LGTM w/comments.
>
>
>
https://codereview.chromium.org/104673003/diff/40001/ppapi/shared_impl/ppapi_...
> File ppapi/shared_impl/ppapi_nacl_channel_args.h (right):
>
>
https://codereview.chromium.org/104673003/diff/40001/ppapi/shared_impl/ppapi_...
> ppapi/shared_impl/ppapi_nacl_channel_args.h:22: bool
> supports_dev_channel;
> This and 'off_the_record' don't seem to be initialized properly in the
> .cc file.

Done.

>
> https://codereview.chromium.org/104673003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2013-12-11 21:41:04]

+joi for content/public

[teravest, 2013-12-11 21:41:35]

+piman for content/ppapi_plugin

[Jói, 2013-12-12 11:03:45]

//content/public LGTM.

[commit-bot: I haz the power, 2013-12-12 15:28:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/104673003/20002

[commit-bot: I haz the power, 2013-12-12 15:50:52]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-12 15:54:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/104673003/70001

[commit-bot: I haz the power, 2013-12-12 20:42:10]

Change committed as 240398