LayoutTests/svg/repaint/fecomponenttransfer-in1-change.svg - Issue 1046673006: Add svgAttributeChanged function to SVGFEComponentTransferElement class

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/repaint/fecomponenttransfer-in1-change.svg

Issue 1046673006: Add svgAttributeChanged function to SVGFEComponentTransferElement class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: modified testcases. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-amplitude-attr.js ('K') | « LayoutTests/svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-type-prop.js ('k') | LayoutTests/svg/repaint/fecomponenttransfer-in1-change-expected.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlin k"

	2 width="300" height="300" onload="runRepaintAndPixelTest()">
	fs 2015/04/01 16:21:41 Should be no need to make a pixel test for this - Should be no need to make a pixel test for this - repaint is enough (a reftest would've worked too.)
	3 <script xlink:href="../../fast/repaint/resources/text-based-repaint.js" />
	fs 2015/04/01 16:21:41 If you put the test in an HTML wrapper you can dro If you put the test in an HTML wrapper you can drop a lot of the ugliness: <!DOCTYPE html> <script src="../../fast/repaint/resources/text-based-repaint.js"></script> <script> function ... onload = runRepaintTest; </script> <svg> ... </svg> (no xlink:href, no CDATA, no xmlns)
	4 <script><![CDATA[

	5 function repaintTest() {

	6 var fe = document.getElementById("fe");

	7 fe.in1.baseVal = "SourceGraphic";

	8 }

	9 ]]></script>

	10 <linearGradient id="MyGradient" gradientUnits="userSpaceOnUse" x1="10" y1="0" x2 ="590" y2="0">
	fs 2015/04/01 16:21:41 There should be no need for a gradient here. Just There should be no need for a gradient here. Just use a simple color ("green").
	11 <stop offset="0" stop-color="#00ff00"/>

	12 <stop offset="1" stop-color="#000000"/>

	13 </linearGradient>

	14 <filter id="SourceGraphic" x="0%" y="0%" width="100%" height="100%">
	fs 2015/04/01 16:21:41 Just call it something simple like 'f' ('SourceGra Just call it something simple like 'f' ('SourceGraphic' is easily confusable with the filter references) Also, you don't need the percentage here - actually, just leave out x/y/etc because the defaults should work out fine here.
	15 <feComponentTransfer id="fe" in="SourceAlpha">

	16 <feFuncG type="gamma" amplitude="1" exponent="0.5" offset="0"/>
	fs 2015/04/01 16:21:41 I think you could just use type="identity" here. I think you could just use type="identity" here.
	17 </feComponentTransfer>

	18 </filter>

	19 <rect x="0" y="0" width="100" height="100" fill="url(#MyGradient)" filter="url(# SourceGraphic)"/>
	fs 2015/04/01 16:21:41 Drop x="0" and y="0" (they're the default values) Drop x="0" and y="0" (they're the default values)
	20 </svg>

OLD	NEW