Preview of a first step towards unification of hydrogen calls

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 73 matching lines @@
       shared_info_(Handle<SharedFunctionInfo>(closure->shared())),
       script_(Handle<Script>(Script::cast(shared_info_->script()))),
       context_(closure->context()),
       osr_ast_id_(BailoutId::None()),
       osr_pc_offset_(0),
       parameter_count_(0) {
   Initialize(script_->GetIsolate(), BASE, zone);
 }
 
 
+void CompilationInfo::CreateCodeObject() {

[Toon Verwaest, 2013/12/18 16:11:41]

That's a funny name. It doesn't actually create a code object, it just
initializes the local variable to undefined...

[Jarin, 2013/12/30 15:15:47]

I am sorry, the whole CodeObject business is not necessary anymore, so I just
got rid of the changes.

+  closure_code_object_ = Handle<Object>(isolate()->heap()->undefined_value(),
+                                        isolate());

[Toon Verwaest, 2013/12/18 16:11:41]

isolate()->factory()->undefined_value() is already a handle.

+}
+
 CompilationInfo::CompilationInfo(HydrogenCodeStub* stub,
                                  Isolate* isolate,
                                  Zone* zone)
     : flags_(LanguageModeField::encode(CLASSIC_MODE) |
              IsLazy::encode(true)),
       osr_ast_id_(BailoutId::None()),
       osr_pc_offset_(0),
       parameter_count_(0) {
   Initialize(isolate, STUB, zone);
   code_stub_ = stub;
@@ skipping 197 matching lines @@
                                                     time_taken_to_optimize_,
                                                     time_taken_to_codegen_);
   }
 }
 
 
 // A return value of true indicates the compilation pipeline is still
 // going, not necessarily that we optimized the code.
 static bool MakeCrankshaftCode(CompilationInfo* info) {
   RecompileJob job(info);
+
+  info->CreateCodeObject();
+
   RecompileJob::Status status = job.CreateGraph();
 
   if (status != RecompileJob::SUCCEEDED) {
     return status != RecompileJob::FAILED;
   }
   status = job.OptimizeGraph();
   if (status != RecompileJob::SUCCEEDED) {
     status = job.AbortOptimization();
     return status != RecompileJob::FAILED;
   }
@@ skipping 747 matching lines @@
   if (!isolate->optimizing_compiler_thread()->IsQueueAvailable()) {
     if (FLAG_trace_concurrent_recompilation) {
       PrintF("  ** Compilation queue full, will retry optimizing ");
       closure->PrintName();
       PrintF(" on next run.\n");
     }
     return false;
   }
 
   SmartPointer<CompilationInfo> info(new CompilationInfoWithZone(closure));
+
   Handle<SharedFunctionInfo> shared = info->shared_info();
 
   if (compiling_for_osr) {
     BailoutId osr_ast_id = unoptimized->TranslatePcOffsetToAstId(osr_pc_offset);
     ASSERT(!osr_ast_id.IsNone());
     info->SetOptimizing(osr_ast_id);
     info->SetOsrInfo(unoptimized, osr_pc_offset);
 
     if (FLAG_trace_osr) {
       PrintF("[COSR - attempt to queue ");
@@ skipping 15 matching lines @@
 
     if (!compiling_for_osr && InstallCodeFromOptimizedCodeMap(info.get())) {
       return true;
     }
 
     if (Parser::Parse(info.get())) {
       LanguageMode language_mode = info->function()->language_mode();
       info->SetLanguageMode(language_mode);
       shared->set_language_mode(language_mode);
       info->SaveHandles();
+      info->CreateCodeObject();
 
       if (Rewriter::Rewrite(info.get()) && Scope::Analyze(info.get())) {
         RecompileJob* job = new(info->zone()) RecompileJob(info.get());
         RecompileJob::Status status = job->CreateGraph();
         if (status == RecompileJob::SUCCEEDED) {
           info.Detach();
           unoptimized->set_profiler_ticks(0);
           isolate->optimizing_compiler_thread()->QueueForOptimization(job);
           ASSERT(!isolate->has_pending_exception());
           return true;
@@ skipping 237 matching lines @@
   AllowHandleDereference allow_deref;
   bool tracing_on = info()->IsStub()
       ? FLAG_trace_hydrogen_stubs
       : (FLAG_trace_hydrogen &&
          info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter));
   return (tracing_on &&
       OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
 }
 
 } }  // namespace v8::internal