[bindings] Cleanup ScriptFunctionCall for unused methods.

[bindings] Cleanup ScriptFunctionCall for unused methods.

R=haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192720

[vivekg, 2015-03-28 12:12:48]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-03-28 12:12:49]

Trivial cleanup.

[haraken, 2015-03-28 12:16:25]

LGTM

[Yuki, 2015-03-28 12:19:26]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2015-03-28 12:19:27]

https://codereview.chromium.org/1046553002/diff/1/Source/bindings/core/v8/Scr...
File Source/bindings/core/v8/ScriptFunctionCall.h (left):

https://codereview.chromium.org/1046553002/diff/1/Source/bindings/core/v8/Scr...
Source/bindings/core/v8/ScriptFunctionCall.h:48: void appendArgument(const
char*);
Are you sure that you're not using implicit conversion from const char* to const
String& ?

[vivekg, 2015-03-28 12:30:55]

On 2015/03/28 at 12:19:27, yukishiino wrote:
>
https://codereview.chromium.org/1046553002/diff/1/Source/bindings/core/v8/Scr...
> File Source/bindings/core/v8/ScriptFunctionCall.h (left):
> 
>
https://codereview.chromium.org/1046553002/diff/1/Source/bindings/core/v8/Scr...
> Source/bindings/core/v8/ScriptFunctionCall.h:48: void appendArgument(const
char*);
> Are you sure that you're not using implicit conversion from const char* to
const String& ?

Thanks for your feedback and a valid concern raised.
A quick grepping, `git grep -n10 [.\>]appendArgument` inside WebKit/Source
doesn't yield any call site using 'const char*' and using the implicit
conversion. 
So this should be safe to remove.

[Yuki, 2015-03-28 12:50:08]

Thanks for checking.
lgtm.

[vivekg, 2015-03-28 12:51:38]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2015-03-28 12:51:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1046553002/1

[commit-bot: I haz the power, 2015-03-28 13:05:39]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192720