Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 104653007: Renamed DesktopCaptureDeviceAsh to DesktopCaptureDeviceAura (Closed)

Created:
7 years ago by Sergey Ulanov
Modified:
7 years ago
Reviewers:
jam, hshi1
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Renamed DesktopCaptureDeviceAsh to DesktopCaptureDeviceAura The capturer will beused for Aura windows and is not Ash-specific. BUG=295102 R=hshi@chromium.org TBR=jam@chromium.org (trivial changes in gyp files) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238837

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -521 lines) Patch
D content/browser/renderer_host/media/desktop_capture_device_ash.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/browser/renderer_host/media/desktop_capture_device_ash.cc View 1 chunk +0 lines, -327 lines 0 comments Download
D content/browser/renderer_host/media/desktop_capture_device_ash_unittest.cc View 1 chunk +0 lines, -115 lines 0 comments Download
A + content/browser/renderer_host/media/desktop_capture_device_aura.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + content/browser/renderer_host/media/desktop_capture_device_aura.cc View 2 chunks +9 lines, -9 lines 0 comments Download
A + content/browser/renderer_host/media/desktop_capture_device_aura_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
7 years ago (2013-12-04 22:35:34 UTC) #1
hshi1
lgtm
7 years ago (2013-12-04 22:36:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/104653007/40001
7 years ago (2013-12-04 22:39:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=197269
7 years ago (2013-12-04 23:07:06 UTC) #4
Sergey Ulanov
7 years ago (2013-12-05 00:56:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r238837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698