Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 104653002: Revert of Disable TestRestoreGeometryCacheChange on all platforms, as it also flakes on WinXP. (Closed)

Created:
7 years ago by mlamouri (slow - plz ping)
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/104333002/ Reason for revert: Hopefully cl 100393008 should improve things on Windows Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/apps/app_window_browsertest.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mlamouri (slow - plz ping)
Created Revert of Disable TestRestoreGeometryCacheChange on all platforms, as it also flakes on WinXP.
7 years ago (2013-12-04 14:30:28 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-04 14:30:35 UTC) #2
mlamouri (slow - plz ping)
Patrick, TestRestoreGeometryCacheChange does not seem to fail on those try runs. PTAL.
7 years ago (2013-12-04 19:59:11 UTC) #3
mlamouri (slow - plz ping)
7 years ago (2013-12-04 21:50:13 UTC) #4
benwells
On 2013/12/04 21:50:13, Mounir Lamouri wrote: Can we get more try runs before reenabling? Flaky ...
7 years ago (2013-12-04 23:41:48 UTC) #5
mlamouri (slow - plz ping)
On 2013/12/04 23:41:48, benwells wrote: > On 2013/12/04 21:50:13, Mounir Lamouri wrote: > > Can ...
7 years ago (2013-12-10 14:14:07 UTC) #6
benwells
On 2013/12/10 14:14:07, Mounir Lamouri wrote: > On 2013/12/04 23:41:48, benwells wrote: > > On ...
7 years ago (2013-12-10 23:56:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/104653002/1
7 years ago (2013-12-11 12:16:39 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-11 15:40:16 UTC) #9
Message was sent while issue was closed.
Change committed as 240112

Powered by Google App Engine
This is Rietveld 408576698