Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 104643004: Fix broken task handling in Files app. (Closed)

Created:
7 years ago by mtomasz
Modified:
7 years ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix broken task handling in Files app. This patch fixes a recent regression caused by refactoring paths to Entries. It is mounting and archive, and recovering after crash. TEST=Tested manually by mounting a zip file. BUG=326037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239191

Patch Set 1 #

Patch Set 2 : Fix recovering. #

Total comments: 2

Patch Set 3 : Cleaned up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_tasks.js View 1 2 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtomasz
@hirono: PTAL. Thanks!
7 years ago (2013-12-05 05:59:40 UTC) #1
hirono
lgtm with a nit! https://codereview.chromium.org/104643004/diff/20001/chrome/browser/resources/file_manager/foreground/js/file_manager.js File chrome/browser/resources/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/104643004/diff/20001/chrome/browser/resources/file_manager/foreground/js/file_manager.js#newcode1491 chrome/browser/resources/file_manager/foreground/js/file_manager.js:1491: console.log(directoryEntry, opt_selectionEntry, opt_suggestedName); nit: Please ...
7 years ago (2013-12-05 08:32:35 UTC) #2
mtomasz
https://codereview.chromium.org/104643004/diff/20001/chrome/browser/resources/file_manager/foreground/js/file_manager.js File chrome/browser/resources/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/104643004/diff/20001/chrome/browser/resources/file_manager/foreground/js/file_manager.js#newcode1491 chrome/browser/resources/file_manager/foreground/js/file_manager.js:1491: console.log(directoryEntry, opt_selectionEntry, opt_suggestedName); On 2013/12/05 08:32:36, hirono wrote: > ...
7 years ago (2013-12-06 05:14:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/104643004/40001
7 years ago (2013-12-06 05:15:39 UTC) #4
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=32401
7 years ago (2013-12-06 05:57:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/104643004/40001
7 years ago (2013-12-06 06:02:22 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=32435
7 years ago (2013-12-06 06:39:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/104643004/40001
7 years ago (2013-12-06 08:10:31 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-06 13:22:36 UTC) #9
Message was sent while issue was closed. 
Change committed as 239191

Powered by Google App Engine
This is Rietveld 408576698