[bindings] Remove History.(push|replace)State custom bindings

[bindings] Remove History.(push|replace)State custom bindings

BUG=345519
R=haraken@chromium.org, jl@opera.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193006

[vivekg, 2015-04-01 07:05:14]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-04-01 07:05:14]

PTAL, thanks.

[bashi, 2015-04-01 09:23:39]

bashi@chromium.org changed reviewers:
+ bashi@chromium.org

[bashi, 2015-04-01 09:23:40]

https://codereview.chromium.org/1046423002/diff/1/Source/bindings/core/v8/cus...
File Source/bindings/core/v8/custom/V8HistoryCustom.cpp (left):

https://codereview.chromium.org/1046423002/diff/1/Source/bindings/core/v8/cus...
Source/bindings/core/v8/custom/V8HistoryCustom.cpp:47:
V8HiddenValue::deleteHiddenValue(info.GetIsolate(), info.Holder(),
V8HiddenValue::state(info.GetIsolate()));
Help me understand: Not directly related to this CL, but why do we need to
remove cached value explicitly? In other words, why making stateChanged() return
true doesn't work?

[vivekg, 2015-04-01 09:40:49]

Though I am not sure why the deleteHiddenValue came here at the first place.

https://codereview.chromium.org/1046423002/diff/1/Source/bindings/core/v8/cus...
File Source/bindings/core/v8/custom/V8HistoryCustom.cpp (left):

https://codereview.chromium.org/1046423002/diff/1/Source/bindings/core/v8/cus...
Source/bindings/core/v8/custom/V8HistoryCustom.cpp:47:
V8HiddenValue::deleteHiddenValue(info.GetIsolate(), info.Holder(),
V8HiddenValue::state(info.GetIsolate()));
On 2015/04/01 at 09:23:40, bashi1 wrote:
> Help me understand: Not directly related to this CL, but why do we need to
remove cached value explicitly? In other words, why making stateChanged() return
true doesn't work?

Agreed and it makes perfect sense to have stateChanged return true than having
either the custom binding or explicit clearing.

[vivekg, 2015-04-01 11:33:44]

On 2015/04/01 at 09:23:40, bashi wrote:
>
https://codereview.chromium.org/1046423002/diff/1/Source/bindings/core/v8/cus...
> File Source/bindings/core/v8/custom/V8HistoryCustom.cpp (left):
> 
>
https://codereview.chromium.org/1046423002/diff/1/Source/bindings/core/v8/cus...
> Source/bindings/core/v8/custom/V8HistoryCustom.cpp:47:
V8HiddenValue::deleteHiddenValue(info.GetIsolate(), info.Holder(),
V8HiddenValue::state(info.GetIsolate()));
> Help me understand: Not directly related to this CL, but why do we need to
remove cached value explicitly? In other words, why making stateChanged() return
true doesn't work?

Hooray! Looks like we don't need this custom handling at all as the stateChanged
is working as expected. So this turns out to be just a cleanup.
PTAL and thanks for the investigation.

[vivekg, 2015-04-01 14:08:01]

All bots green as well now! :)

[vivekg, 2015-04-02 07:06:03]

On 2015/04/01 14:08:01, vivekg_ wrote:
> All bots green as well now! :)

Gentle ping.

[Jens Widell, 2015-04-02 07:33:00]

LGTM

[vivekg, 2015-04-02 07:33:43]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2015-04-02 07:34:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1046423002/20001

[haraken, 2015-04-02 07:41:32]

LGTM

[commit-bot: I haz the power, 2015-04-02 07:43:05]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193006