Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1046343002: [Android] Clean up old_inteface in build/android/buildbot/ (Closed)

Created:
5 years, 8 months ago by jbudorick
Modified:
5 years, 8 months ago
Reviewers:
klundberg, navabi1, navabi
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Clean up old_inteface in build/android/buildbot/ BUG=267773 Committed: https://crrev.com/2fec794a0da170d0d83b778a32d27492d7aad04a Cr-Commit-Position: refs/heads/master@{#324082}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -41 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 2 chunks +44 lines, -41 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
jbudorick
5 years, 8 months ago (2015-04-01 01:15:30 UTC) #2
jbudorick
ping https://codereview.chromium.org/1046343002/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/1046343002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode64 build/android/buildbot/bb_device_status_check.py:64: try: Note that catching exceptions here is a ...
5 years, 8 months ago (2015-04-06 17:29:30 UTC) #3
navabi
lgtm thanks for the fix John. https://codereview.chromium.org/1046343002/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/1046343002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode64 build/android/buildbot/bb_device_status_check.py:64: try: On 2015/04/06 ...
5 years, 8 months ago (2015-04-07 17:55:18 UTC) #5
navabi1
lgtm
5 years, 8 months ago (2015-04-07 17:55:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1046343002/1
5 years, 8 months ago (2015-04-07 17:57:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 18:58:15 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 18:59:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fec794a0da170d0d83b778a32d27492d7aad04a
Cr-Commit-Position: refs/heads/master@{#324082}

Powered by Google App Engine
This is Rietveld 408576698