DescriptionRevert "Added support for NaCl IO to use the IRT Extension API."
This reverts commit 3183230ac54a9b443f6e67a64121a0c3ee734e6b.
There is some subtle behavior when certain interfaces are not available,
and how libnacl falls-back to other interfaces.
For example, the fdio interface is not available on PNaCl, but the
fdio-dev interface is. libnacl has an early fallback that attempts to
query fdio, and if it is not available, will fill in its fdio interface
struct with the fdio-dev pointers. This logic is necessary to get output
to the Chrome console. In kernel_wrap_newlib, this behavior is preserved
because the "real" pointers are grabbed directly from the newlib
structures. In The IRT extension API, this fails because it queries the
interfaces directly.
If we query the interface pointers directly, we'll have to reimplement
the fall-back logic. Perhaps this is worth doing, but the IRT extension
API is still not implemented for glibc, so the benefits of it are
minimal at this point.
BUG=http://crbug.com/472185
R=sbc@chromium.org
CC=dyen@chromium.org
Committed: https://crrev.com/8c7a8d9ac7b85e64f69df7956c461122057bad91
Cr-Commit-Position: refs/heads/master@{#323260}
Patch Set 1 #
Messages
Total messages: 11 (3 generated)
|