Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1046233002: Update the gyp_remaining target after recent progress. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the gyp_remaining target after recent progress. BUG=471920, 461019 TEST=trybots R=dpranke@chromium.org Committed: https://crrev.com/336944731ebdcb46a41d91bbb51cef2fda0d6c16 Cr-Commit-Position: refs/heads/master@{#323103}

Patch Set 1 #

Patch Set 2 : add to gn_all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/gn_migration.gypi View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tfarina
5 years, 8 months ago (2015-03-31 19:12:25 UTC) #1
brettw
Hey Thiago, you don't have to CC me on all of these (or is it ...
5 years, 8 months ago (2015-03-31 19:23:44 UTC) #3
Dirk Pranke
lgtm assuming you also add gles2_conform_support and gles2_conform_test to the top level gn_all target, and ...
5 years, 8 months ago (2015-03-31 19:27:20 UTC) #4
tfarina
On Tue, Mar 31, 2015 at 4:23 PM, <brettw@chromium.org> wrote: > Hey Thiago, you don't ...
5 years, 8 months ago (2015-03-31 19:36:10 UTC) #5
tfarina
Added to gn_all with TODOs. Pushing to CQ. UnCCing Brett :/
5 years, 8 months ago (2015-03-31 19:47:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1046233002/20001
5 years, 8 months ago (2015-03-31 19:48:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 20:47:21 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 20:48:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/336944731ebdcb46a41d91bbb51cef2fda0d6c16
Cr-Commit-Position: refs/heads/master@{#323103}

Powered by Google App Engine
This is Rietveld 408576698