rebaseline_server: add "deep linking" to allow bookmarking of particular views

rebaseline_server: add "deep linking" to allow bookmarking of particular views
(SkipBuildbotRuns)

R=jcgregorio@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12513

[epoger, 2013-12-04 19:49:22]

https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/index.html (right):

https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/index.html:12: <a
href="/static/view.html#/view.html?resultsToLoad=failures">
Changed this to me more in line with the URLs generated by the web page itself. 
It would work OK either way.

https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:270: var value = nameValuePairs[name];
The loop setup is annoyingly copy-pasted for the 3 lists (simpleUrlParams,
categoryUrlParams, setUrlParams).  Any idea for how I could have less
boilerplate code?

I guess I could use http://docs.angularjs.org/api/angular.forEach (which just
replaces the plain-old-Javascript boilerplate with harder-to-understand
AngularJS boilerplate)

Or I could combine the 3 lists into 1, like this:
urlParams = {
  'resultsToLoad': 'simple',
  'displayLimitPending': 'simple',
  'builder': 'category',
  ...
}

or this...
urlParams = {
  'simple': ['resultsToLoad', 'displayLimitPending'],
  'category': ['builder', 'test'],
  ...
}

In any of those approaches, IMO, the cure is worse than the disease.

Is there some other approach I'm not thinking of????

[epoger, 2013-12-04 19:51:26]

P.S. You can try it out at http://172.24.179.183:9299

[jcgregorio, 2013-12-05 15:05:08]

https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:270: var value = nameValuePairs[name];
How about a dictionary that maps query parameter names to the action you want to
perform on said query parameter value:

queryParamParsers = {
   'resultsToLoad': fn_to_map_query_param_to_scope,
   'displayLimitPending': fn_to_map_query_param_to_scope,
   ...
   'builder': fn_to_map_query_param_to_category,
   ...
   'hiddenConfigs': fn_to_map_query_param_to_toggle,
   ...
}

[epoger, 2013-12-05 17:08:49]

Whaddaya think of patchset 2?

https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:270: var value = nameValuePairs[name];
On 2013/12/05 15:05:09, jcgregorio wrote:
> How about a dictionary that maps query parameter names to the action you want
to
> perform on said query parameter value:
> 
> queryParamParsers = {
>    'resultsToLoad': fn_to_map_query_param_to_scope,
>    'displayLimitPending': fn_to_map_query_param_to_scope,
>    ...
>    'builder': fn_to_map_query_param_to_category,
>    ...
>    'hiddenConfigs': fn_to_map_query_param_to_toggle,
>    ...
> }

Hmm, interesting idea!  I played with it for a while.

I don't know if it's better or worse, but it's definitely different.  Looks like
it was written by a Java/C++ programmer, who's been writing Python for too long,
and is now pretending to be a Javascript programmer.  Which I guess it was.

[jcgregorio, 2013-12-05 17:49:23]

On 2013/12/05 17:08:49, epoger wrote:
> Whaddaya think of patchset 2?
> 
>
https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
> File gm/rebaseline_server/static/loader.js (right):
> 
>
https://codereview.chromium.org/104623003/diff/1/gm/rebaseline_server/static/...
> gm/rebaseline_server/static/loader.js:270: var value = nameValuePairs[name];
> On 2013/12/05 15:05:09, jcgregorio wrote:
> > How about a dictionary that maps query parameter names to the action you
want
> to
> > perform on said query parameter value:
> > 
> > queryParamParsers = {
> >    'resultsToLoad': fn_to_map_query_param_to_scope,
> >    'displayLimitPending': fn_to_map_query_param_to_scope,
> >    ...
> >    'builder': fn_to_map_query_param_to_category,
> >    ...
> >    'hiddenConfigs': fn_to_map_query_param_to_toggle,
> >    ...
> > }
> 
> Hmm, interesting idea!  I played with it for a while.
> 
> I don't know if it's better or worse, but it's definitely different.  Looks
like
> it was written by a Java/C++ programmer, who's been writing Python for too
long,
> and is now pretending to be a Javascript programmer.  Which I guess it was.

LGTM

[epoger, 2013-12-05 18:03:27]

Committed patchset #3 manually as r12513 (presubmit successful).