Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1046173002: [turbofan] Fix properties of IrOpcode::kThrow operator. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix properties of IrOpcode::kThrow operator. This changes the IrOpcode::kThrow operator to have kNoThrow property, which sounds unintuitive, but holds for our graphs. The operators is used to indicate exceptional control flow out of the function, but in itself does not throw, the throwing is done by a runtime call. R=titzer@chromium.org TEST=unittests/CommonOperatorTest/CommonSharedOperatorTest.Properties Committed: https://crrev.com/48c185fe75350954596ae23d0d8e407ecb42ac61 Cr-Commit-Position: refs/heads/master@{#27541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/common-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 8 months ago (2015-03-31 13:19:38 UTC) #1
titzer
On 2015/03/31 13:19:38, Michael Starzinger wrote: LGTM
5 years, 8 months ago (2015-03-31 13:28:56 UTC) #2
titzer
On 2015/03/31 13:19:38, Michael Starzinger wrote: LGTM
5 years, 8 months ago (2015-03-31 13:28:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1046173002/1
5 years, 8 months ago (2015-03-31 13:30:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 13:44:02 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 13:44:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48c185fe75350954596ae23d0d8e407ecb42ac61
Cr-Commit-Position: refs/heads/master@{#27541}

Powered by Google App Engine
This is Rietveld 408576698