Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1046073002: Add read-only mode to CommandLine that optimizes HasSwitch(const char*). (Closed)

Created:
5 years, 8 months ago by jackhou1
Modified:
5 years, 6 months ago
Reviewers:
CC:
chromium-reviews, erikwright+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@whitelisted
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add read-only mode to CommandLine that optimizes HasSwitch(const char*). Closing in favour of https://codereview.chromium.org/1063933002/ BUG=472383

Patch Set 1 #

Patch Set 2 : Sync and rebase #

Patch Set 3 : Only check upper case on Windows. #

Patch Set 4 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -15 lines) Patch
M base/command_line.h View 1 4 chunks +20 lines, -0 lines 0 comments Download
M base/command_line.cc View 1 2 16 chunks +64 lines, -12 lines 0 comments Download
M base/command_line_unittest.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698