Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 104593014: Revert 164125 "ASSERTION FAILED: !object || object->isTable()" (Closed)

Created:
6 years, 11 months ago by inferno
Modified:
6 years, 11 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Revert 164125 "ASSERTION FAILED: !object || object->isTable()" Caused multiple use-after-free bugs. See bugs 330626, 331029. > ASSERTION FAILED: !object || object->isTable() > > The issue is caused by call sites of > RenderBlock::addChildIgnoringAnonymousColumnBlocks > that basically bypass the RenderTable::addChild logic causing > all sorts of mayhem. The fix I decided on is to fix the previous > RenderBlock function as it's the safest approach to the current > madness. > > This change adds an extra ASSERT into RenderObjectChildList to > catch further problem earlier. > > BUG=309421 > > Review URL: https://codereview.chromium.org/111873005 TBR=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -54 lines) Patch
D trunk/LayoutTests/fast/table/bad-table-insert-anonymous-multi-column.html View 1 chunk +0 lines, -38 lines 0 comments Download
D trunk/LayoutTests/fast/table/bad-table-insert-anonymous-multi-column-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/Source/core/rendering/RenderBlock.cpp View 2 chunks +2 lines, -12 lines 0 comments Download
M trunk/Source/core/rendering/RenderObjectChildList.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
inferno
6 years, 11 months ago (2014-01-01 00:45:28 UTC) #1
inferno
6 years, 11 months ago (2014-01-01 00:45:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r164405.

Powered by Google App Engine
This is Rietveld 408576698