Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: sql/connection.h

Issue 104593010: AppCache: Run a quick integrity check on the sqlite database when opening. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sql/connection.h
diff --git a/sql/connection.h b/sql/connection.h
index ec76e3be89a133075f287cfb917cdd2c5ba91e30..5dd2f41fadff449dd9bfd307adb29cdcfb963aff 100644
--- a/sql/connection.h
+++ b/sql/connection.h
@@ -150,11 +150,14 @@ class SQL_EXPORT Connection {
// histogram is recorded.
void AddTaggedHistogram(const std::string& name, size_t sample) const;
- // Run "PRAGMA integrity_check" and post each line of results into
- // |messages|. Returns the success of running the statement - per
- // the SQLite documentation, if no errors are found the call should
- // succeed, and a single value "ok" should be in messages.
- bool IntegrityCheck(std::vector<std::string>* messages);
+ // Run "PRAGMA integrity_check" or "quick_check" and post each line of
+ // results into |messages|. Returns the success of running the
+ // statement - per the SQLite documentation, if no errors are found the
+ // call should succeed, and a single value "ok" should be in messages.
+ bool FullIntegrityCheck(std::vector<std::string>* messages)
+ WARN_UNUSED_RESULT;
+ bool QuickIntegrityCheck(std::vector<std::string>* messages)
+ WARN_UNUSED_RESULT;
// Initialization ------------------------------------------------------------
@@ -540,6 +543,10 @@ class SQL_EXPORT Connection {
// case for const functions).
scoped_refptr<StatementRef> GetUntrackedStatement(const char* sql) const;
+ bool IntegrityCheckHelper(
+ const char* pragma_sql,
+ std::vector<std::string>* messages) WARN_UNUSED_RESULT;
+
// The actual sqlite database. Will be NULL before Init has been called or if
// Init resulted in an error.
sqlite3* db_;

Powered by Google App Engine
This is Rietveld 408576698