AppCache: Run a quick integrity check on the sqlite database when opening.

chrome/browser/history/thumbnail_database.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/thumbnail_database.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 122 matching lines @@
   base::StringAppendF(&debug_info, "SQLITE_CORRUPT, integrity_check:\n");
 
   // Check files up to 8M to keep things from blocking too long.
   const size_t kMaxIntegrityCheckSize = 8192;
   if (startup_kb > kMaxIntegrityCheckSize) {
     base::StringAppendF(&debug_info, "too big %" PRIuS "\n", startup_kb);
   } else {
     std::vector<std::string> messages;
 
     const base::TimeTicks before = base::TimeTicks::Now();
-    db->IntegrityCheck(&messages);
+    db->FullIntegrityCheck(&messages);

[michaeln, 2013/12/09 19:15:51]

ooops, have to check the return value here

[Scott Hess - ex-Googler, 2013/12/09 20:27:27]

FYI, IntegrityCheck() was only added for this code to build fake-crash-dump
diagnostics.  So the API may not be anything like what a real client might want.

IMHO, nobody but diagnostics tools are going to want the actual messages.  I
think it would be perfectly fine to shift your new changes towards an API with a
bool return and no messages, and WARN_UNUSED_RESULT as appropriate.

     base::StringAppendF(&debug_info, "# %" PRIx64 " ms, %" PRIuS " records\n",
                         (base::TimeTicks::Now() - before).InMilliseconds(),
                         messages.size());
 
     // SQLite returns up to 100 messages by default, trim deeper to
     // keep close to the 2000-character size limit for dumping.
     //
     // TODO(shess): If the first 20 tend to be actionable, test if
     // passing the count to integrity_check makes it exit earlier.  In
     // that case it may be possible to greatly ease the size
@@ skipping 1273 matching lines @@
   meta_table_.SetVersionNumber(7);
   meta_table_.SetCompatibleVersionNumber(std::min(7, kCompatibleVersionNumber));
   return true;
 }
 
 bool ThumbnailDatabase::IsFaviconDBStructureIncorrect() {
   return !db_.IsSQLValid("SELECT id, url, icon_type FROM favicons");
 }
 
 }  // namespace history