Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 104593005: Introduce DEFINE_INLINE_BOX_TYPE_CASTS, and use it (Closed)

Created:
7 years ago by gyuyoung-inactive
Modified:
7 years ago
Reviewers:
tkent
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce DEFINE_INLINE_BOX_TYPE_CASTS, and use it As a step to use DEFINE_TYPE_CASTS, this cl introduce DEFINE_INLINE_BOX_TYPE_CASTS. InlineFlowBox, InlineTextBox, SVGInlineTextBox, SVGInlineFlowBox, and SVGRootInlineBox can use it to generate toFoo() type case helper functions. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163300

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -43 lines) Patch
M Source/core/rendering/InlineBox.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/InlineTextBox.h View 1 2 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineFlowBox.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gyuyoung-inactive
Add tkent.
7 years ago (2013-12-05 08:21:32 UTC) #1
tkent
How about updating InlineTextBox too?
7 years ago (2013-12-05 08:46:22 UTC) #2
gyuyoung-inactive
On 2013/12/05 08:46:22, tkent wrote: > How about updating InlineTextBox too? Ok i will update ...
7 years ago (2013-12-05 08:57:03 UTC) #3
gyuyoung-inactive
On 2013/12/05 08:57:03, gyuyoung wrote: > On 2013/12/05 08:46:22, tkent wrote: > > How about ...
7 years ago (2013-12-05 23:00:23 UTC) #4
tkent
lgtm
7 years ago (2013-12-05 23:38:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/104593005/40001
7 years ago (2013-12-05 23:40:10 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-06 03:33:57 UTC) #7
Message was sent while issue was closed.
Change committed as 163300

Powered by Google App Engine
This is Rietveld 408576698