Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Issue 1045913003: Refactor device/BUILD.gn to list source files only once. (Closed)

Created:
5 years, 8 months ago by scheib
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor device/BUILD.gn to list source files only once. Updating device/BUILD.gn to follow GN style guide, listing source and deps items only once guarded by conditionals. (Not listing all, then removing some based on conditions). https://code.google.com/p/chromium/wiki/GNStyleGuide#Sources Prepares BUILD.gn for additional sources/deps logic expected to add android support for device_unittests. BUG=471536 Committed: https://crrev.com/7a4cf04e2b9e2c3421cd7137afc39ec3c9e6eb46 Cr-Commit-Position: refs/heads/master@{#322978}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -47 lines) Patch
M device/BUILD.gn View 1 5 chunks +32 lines, -47 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
scheib
5 years, 8 months ago (2015-03-30 22:51:01 UTC) #3
Reilly Grant (use Gerrit)
lgtm This looks much better. Thank you.
5 years, 8 months ago (2015-03-30 22:55:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045913003/40001
5 years, 8 months ago (2015-03-31 04:30:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-03-31 04:33:53 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 04:34:21 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a4cf04e2b9e2c3421cd7137afc39ec3c9e6eb46
Cr-Commit-Position: refs/heads/master@{#322978}

Powered by Google App Engine
This is Rietveld 408576698