Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 1045863002: Make checkdeps.py check third_party. (Closed)

Created:
5 years, 8 months ago by jam
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, jzern, je_julie(Not used), vikasa, urvang, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, skal, nektar+watch_chromium.org, yuzo+watch_chromium.org, eme-reviews_chromium.org, stuartmorgan, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Dai Mikurube (NOT FULLTIME)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make checkdeps.py check third_party. For this first cl, it's only checking checked in code. I've had to add DEPS files to make it pass, since some of this code legitimately uses base etc... BUG=469692 R=brettw@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5b6373fbaed471c766ec691ad2c816abbc482d29

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -52 lines) Patch
M DEPS View 2 chunks +2 lines, -4 lines 0 comments Download
A third_party/DEPS View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/android_platform/bionic/tools/relocation_packer/src/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/boringssl/DEPS View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + third_party/cacheinvalidation/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/cld/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download
A + third_party/cld/base/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/fips181/DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/jsoncpp/jsoncpp.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/jsoncpp/overrides/include/json/value.h View 1 chunk +1 line, -1 line 0 comments Download
A third_party/leveldatabase/DEPS View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/canonicalize_string.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libevent/event-config.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/libevent/libevent.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/libjingle/overrides/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libjingle/overrides/allocator_shim/allocator_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/allocator_shim/allocator_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libjingle/overrides/initialize_module.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/liblouis/liblouis_nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/liblouis/nacl_wrapper/DEPS View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/liblouis/nacl_wrapper/liblouis_instance.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/liblouis/nacl_wrapper/liblouis_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/libusb/src/libusb/os/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/libwebp/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A + third_party/libxml/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mach_override/mach_override.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mach_override/udis86.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/modp_b64/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/mozilla/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/mt19937ar/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/npapi/bindings/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/ocmock/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/compiler/plugin.pb.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/compiler/plugin.pb.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/descriptor.pb.cc View 1 chunk +1 line, -1 line 0 comments Download
A third_party/re2/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A + third_party/speex/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/sudden_motion_sensor/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A third_party/tcmalloc/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/widevine/cdm/widevine_cdm_common.h View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/zlib/google/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jam
5 years, 8 months ago (2015-03-30 15:38:00 UTC) #2
brettw
lgtm https://codereview.chromium.org/1045863002/diff/1/third_party/liblouis/nacl_wrapper/DEPS File third_party/liblouis/nacl_wrapper/DEPS (right): https://codereview.chromium.org/1045863002/diff/1/third_party/liblouis/nacl_wrapper/DEPS#newcode8 third_party/liblouis/nacl_wrapper/DEPS:8: specific_include_rules = { Wow, I didn't know we ...
5 years, 8 months ago (2015-03-30 17:50:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045863002/60001
5 years, 8 months ago (2015-04-01 19:40:53 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5b6373fbaed471c766ec691ad2c816abbc482d29 Cr-Commit-Position: refs/heads/master@{#323302}
5 years, 8 months ago (2015-04-01 19:46:06 UTC) #9
jam
5 years, 8 months ago (2015-04-01 19:46:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
5b6373fbaed471c766ec691ad2c816abbc482d29.

Powered by Google App Engine
This is Rietveld 408576698