Don't ignore landmark and related AXObjects, because they should be exposed to

Don't ignore landmark and related AXObjects, because they should be exposed to
assistive technologies.

BUG=253027
TEST=LayoutTest/accessibility/not-ignore-landmark-roles.html
R=dmazzoni@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164498

[dmazzoni, 2014-01-03 18:14:11]

Thanks, this looks great! Just one tiny code suggestion.

https://codereview.chromium.org/104583006/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/104583006/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXObject.cpp:189: return role == ArticleRole ||
Please use a switch statement, and sort them alphabetically.

[Takeshi Kurosawa, 2014-01-04 11:29:23]

On 2014/01/03 18:14:11, Dominic Mazzoni wrote:
> Thanks, this looks great! Just one tiny code suggestion.
> 
>
https://codereview.chromium.org/104583006/diff/1/Source/core/accessibility/AX...
> File Source/core/accessibility/AXObject.cpp (right):
> 
>
https://codereview.chromium.org/104583006/diff/1/Source/core/accessibility/AX...
> Source/core/accessibility/AXObject.cpp:189: return role == ArticleRole ||
> Please use a switch statement, and sort them alphabetically.

Thank you for your review. I uploaded a new patch set.

[dmazzoni, 2014-01-04 23:46:14]

lgtm

[dmazzoni, 2014-01-05 05:17:22]

I manually checked content_browsertests on Windows and all tests still pass, so
I'll CQ this change now.

[commit-bot: I haz the power, 2014-01-05 05:17:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/taken.spc@gmail.com/104583006/90001

[commit-bot: I haz the power, 2014-01-05 05:34:56]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[dmazzoni, 2014-01-06 08:52:22]

Committed patchset #2 manually as r164498 (presubmit successful).