Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: src/libplatform/task-queue.cc

Issue 104583003: [platform] Implement a worker pool (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "v8.h" 28 #include "task-queue.h"
29 29
30 #include "default-platform.h" 30 // TODO(jochen): We should have our own version of checks.h.
31 #include "../checks.h"
31 32
32 namespace v8 { 33 namespace v8 {
33 namespace internal { 34 namespace internal {
34 35
35 36 TaskQueue::TaskQueue() : process_queue_semaphore_(0), terminated_(false) {}
36 DefaultPlatform::DefaultPlatform() {}
37 37
38 38
39 DefaultPlatform::~DefaultPlatform() {} 39 TaskQueue::~TaskQueue() {
40 40 LockGuard<Mutex> guard(&lock_);
41 void DefaultPlatform::CallOnBackgroundThread(Task *task, 41 ASSERT(terminated_);
42 ExpectedRuntime expected_runtime) { 42 ASSERT(task_queue_.empty());
43 // TODO(jochen): implement.
44 task->Run();
45 delete task;
46 } 43 }
47 44
48 45
49 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) { 46 void TaskQueue::Append(Task* task) {
50 // TODO(jochen): implement. 47 LockGuard<Mutex> guard(&lock_);
51 task->Run(); 48 ASSERT(!terminated_);
52 delete task; 49 task_queue_.push(task);
50 process_queue_semaphore_.Signal();
53 } 51 }
54 52
55 53
54 Task* TaskQueue::GetNext() {
55 for (;;) {
56 {
57 LockGuard<Mutex> guard(&lock_);
58 if (!task_queue_.empty()) {
59 Task* result = task_queue_.front();
60 task_queue_.pop();
61 return result;
62 }
63 if (terminated_) {
64 process_queue_semaphore_.Signal();
Hannes Payer (out of office) 2013/12/09 18:50:51 Why do you need that signal? The thread that termi
jochen (gone - plz use gerrit) 2013/12/09 19:04:31 There can be multiple threads waiting on the semap
65 return NULL;
66 }
67 }
68 process_queue_semaphore_.Wait();
69 }
70 }
71
72
73 void TaskQueue::Terminate() {
74 LockGuard<Mutex> guard(&lock_);
75 ASSERT(!terminated_);
76 terminated_ = true;
77 process_queue_semaphore_.Signal();
78 }
79
56 } } // namespace v8::internal 80 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698