Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: src/libplatform/default-platform.h

Issue 104583003: [platform] Implement a worker pool (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #ifndef V8_DEFAULT_PLATFORM_H_ 28 #ifndef V8_LIBPLATFORM_DEFAULT_PLATFORM_H_
29 #define V8_DEFAULT_PLATFORM_H_ 29 #define V8_LIBPLATFORM_DEFAULT_PLATFORM_H_
30 30
31 #include "v8.h" 31 #include "../../include/v8-platform.h"
32 // TODO(jochen): We should have our own version of globals.h.
33 #include "../globals.h"
32 34
33 namespace v8 { 35 namespace v8 {
34 namespace internal { 36 namespace internal {
35 37
38 class TaskQueue;
39 class Thread;
40 class WorkerThread;
41
36 class DefaultPlatform : public Platform { 42 class DefaultPlatform : public Platform {
37 public: 43 public:
38 DefaultPlatform(); 44 DefaultPlatform();
39 virtual ~DefaultPlatform(); 45 virtual ~DefaultPlatform();
40 46
47 // TODO(jochen): This shouldn't be static.
48 static void SetThreadPoolSize(int thread_pool_size);
49
41 // v8::Platform implementation. 50 // v8::Platform implementation.
42 virtual void CallOnBackgroundThread( 51 virtual void CallOnBackgroundThread(
43 Task *task, ExpectedRuntime expected_runtime) V8_OVERRIDE; 52 Task *task, ExpectedRuntime expected_runtime) V8_OVERRIDE;
44 virtual void CallOnForegroundThread(v8::Isolate *isolate, 53 virtual void CallOnForegroundThread(v8::Isolate *isolate,
45 Task *task) V8_OVERRIDE; 54 Task *task) V8_OVERRIDE;
46 55
47 private: 56 private:
57 void EnsureThreadPoolStarted();
58
59 static const int kMaxThreadPoolSize = 4;
60
61 WorkerThread** thread_pool_;
62 // TODO(jochen): This shouldn't be a static.
63 static int thread_pool_size_;
Hannes Payer (out of office) 2013/12/09 18:50:51 I don't think we can have static members here. Thi
jochen (gone - plz use gerrit) 2013/12/09 19:04:31 there's only one default platform per process.
Hannes Payer (out of office) 2013/12/11 12:07:27 As discussed offline, TSAN will not like that in a
64 TaskQueue* queue_;
65
48 DISALLOW_COPY_AND_ASSIGN(DefaultPlatform); 66 DISALLOW_COPY_AND_ASSIGN(DefaultPlatform);
49 }; 67 };
50 68
51 69
52 } } // namespace v8::internal 70 } } // namespace v8::internal
53 71
54 72
55 #endif // V8_DEFAULT_PLATFORM_H_ 73 #endif // V8_LIBPLATFORM_DEFAULT_PLATFORM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698