[platform] Implement a worker pool

src/libplatform/default-platform.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#include "v8.h"
+#include "default-platform.h"
 
-#include "default-platform.h"
+#include <queue>
+
+// TODO(jochen): We should have our own version of checks.h.
+#include "../checks.h"
+// TODO(jochen): Why is cpu.h not in platform/?
+#include "../cpu.h"
+#include "task-queue.h"
+#include "worker-thread.h"
 
 namespace v8 {
 namespace internal {
 
-
-DefaultPlatform::DefaultPlatform() {}
+int DefaultPlatform::thread_pool_size_ = 0;
 
 
-DefaultPlatform::~DefaultPlatform() {}
+DefaultPlatform::DefaultPlatform() : thread_pool_(NULL), queue_(NULL) {}
+
+
+DefaultPlatform::~DefaultPlatform() {
+  if (thread_pool_) {
+    queue_->Terminate();
+    for (int i = 0; i < thread_pool_size_; ++i) {
+      delete thread_pool_[i];
+    }
+    delete[] thread_pool_;
+    delete queue_;
+  }
+}
+
+
+// static
+void DefaultPlatform::SetThreadPoolSize(int thread_pool_size) {
+  ASSERT(thread_pool_size >= 0);

[Hannes Payer (out of office), 2013/12/09 18:50:51]

What about: void DefaultPlatform::SetThreadPoolSize(int thread_pool_size=0)
and setting thread_pool_size_ to CPU::NumberOfProcessorsOnline() if
thread_pool_size==0.

[jochen (gone - plz use gerrit), 2013/12/09 19:04:31]

default parameters are forbidden by the coding style :)

CPU::NumberOfProccessorsOnline() is already used as fallback. However, that
doesn't work in production (which is why we get the number of
ResourceConstraints - see api.cc)

[Hannes Payer (out of office), 2013/12/11 12:07:27]

OK, fine with me.

+  // TODO(jochen): If this wasn't a static member, we should
+  // ASSERT(!thread_pool_);
+  thread_pool_size_ = thread_pool_size;
+}
 
 void DefaultPlatform::CallOnBackgroundThread(Task *task,
                                              ExpectedRuntime expected_runtime) {
-  // TODO(jochen): implement.
-  task->Run();
-  delete task;
+  EnsureThreadPoolStarted();
+  queue_->Append(task);
 }
 
 
 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) {
   // TODO(jochen): implement.
   task->Run();
   delete task;
 }
 
 
+void DefaultPlatform::EnsureThreadPoolStarted() {
+  if (thread_pool_) return;
+  queue_ = new TaskQueue;
+  if (thread_pool_size_ < 1)
+    thread_pool_size_ = CPU::NumberOfProcessorsOnline();
+  thread_pool_size_ = Max(Min(thread_pool_size_, kMaxThreadPoolSize), 1);

[Hannes Payer (out of office), 2013/12/09 18:50:51]

I think this should be handled by SetThreadPoolSize.

[jochen (gone - plz use gerrit), 2013/12/09 19:04:31]

I would have to duplicate this here for the case that SetThreadPoolSize is never
invoked. So why bother?

[Hannes Payer (out of office), 2013/12/11 12:07:27]

OK, you could also invoke SetThreadPool size from here, but fine.

+
+  thread_pool_ = new WorkerThread*[thread_pool_size_];
+
+  for (int i = 0; i < thread_pool_size_; ++i)
+    thread_pool_[i] = new WorkerThread(queue_);
+}
+
 } }  // namespace v8::internal