Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: src/libplatform/default-platform.cc

Issue 104583003: [platform] Implement a worker pool (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/libplatform/default-platform.h ('k') | src/libplatform/task-queue.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "v8.h" 28 #include "default-platform.h"
29 29
30 #include "default-platform.h" 30 #include <queue>
31
32 // TODO(jochen): We should have our own version of checks.h.
33 #include "../checks.h"
34 // TODO(jochen): Why is cpu.h not in platform/?
35 #include "../cpu.h"
36 #include "worker-thread.h"
31 37
32 namespace v8 { 38 namespace v8 {
33 namespace internal { 39 namespace internal {
34 40
35 41
36 DefaultPlatform::DefaultPlatform() {} 42 DefaultPlatform::DefaultPlatform()
43 : initialized_(false) {}
37 44
38 45
39 DefaultPlatform::~DefaultPlatform() {} 46 DefaultPlatform::~DefaultPlatform() {
47 LockGuard<Mutex> guard(&lock_);
48 if (initialized_) {
49 queue_.Terminate();
50 for (std::vector<WorkerThread*>::iterator i = thread_pool_.begin();
51 i != thread_pool_.end(); ++i) {
52 delete *i;
53 }
54 }
55 }
56
57
58 void DefaultPlatform::SetThreadPoolSize(int thread_pool_size) {
59 LockGuard<Mutex> guard(&lock_);
60 ASSERT(thread_pool_size >= 0);
61 if (initialized_) return;
62 initialized_ = true;
63 if (thread_pool_size < 1)
64 thread_pool_size = CPU::NumberOfProcessorsOnline();
65 thread_pool_size = Max(Min(thread_pool_size, kMaxThreadPoolSize), 1);
66
67 for (int i = 0; i < thread_pool_size; ++i)
68 thread_pool_.push_back(new WorkerThread(&queue_));
69 }
40 70
41 void DefaultPlatform::CallOnBackgroundThread(Task *task, 71 void DefaultPlatform::CallOnBackgroundThread(Task *task,
42 ExpectedRuntime expected_runtime) { 72 ExpectedRuntime expected_runtime) {
43 // TODO(jochen): implement. 73 #ifdef DEBUG
44 task->Run(); 74 {
45 delete task; 75 LockGuard<Mutex> guard(&lock_);
76 ASSERT(initialized_);
77 }
78 #endif
79 queue_.Append(task);
46 } 80 }
47 81
48 82
49 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) { 83 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) {
50 // TODO(jochen): implement. 84 // TODO(jochen): implement.
51 task->Run(); 85 task->Run();
52 delete task; 86 delete task;
53 } 87 }
54 88
55
56 } } // namespace v8::internal 89 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/libplatform/default-platform.h ('k') | src/libplatform/task-queue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698