Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1045793002: Determine the right SVGTextMetrics using the correct approach (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Determine the right SVGTextMetrics using the correct approach https://codereview.chromium.org/1041693002/ had a bug with how it determined the SVGTextMetrics cell to use for a certain character/glyph. We need to use SVGTextFragment::metricsListOffset and iterate. BUG=470326 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192817

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
A LayoutTests/svg/text/getextentofchar-nonbmp.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/getextentofchar-nonbmp-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextQuery.cpp View 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Erik Dahlström (inactive)
If this was buggy before, adding a test seems like a good thing to do. ...
5 years, 8 months ago (2015-03-30 12:28:46 UTC) #2
fs
On 2015/03/30 12:28:46, Erik Dahlström wrote: > If this was buggy before, adding a test ...
5 years, 8 months ago (2015-03-30 13:26:40 UTC) #3
fs
https://codereview.chromium.org/1045793002/diff/1/Source/core/layout/svg/SVGTextQuery.cpp File Source/core/layout/svg/SVGTextQuery.cpp (right): https://codereview.chromium.org/1045793002/diff/1/Source/core/layout/svg/SVGTextQuery.cpp#newcode435 Source/core/layout/svg/SVGTextQuery.cpp:435: return textMetricsValues[textMetricsOffset - 1]; On 2015/03/30 13:26:40, fs wrote: ...
5 years, 8 months ago (2015-03-30 14:00:57 UTC) #4
fs
5 years, 8 months ago (2015-03-30 16:15:24 UTC) #6
Erik Dahlström (inactive)
lgtm
5 years, 8 months ago (2015-03-31 08:36:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045793002/20001
5 years, 8 months ago (2015-03-31 09:19:48 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 09:23:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192817

Powered by Google App Engine
This is Rietveld 408576698