Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1045763002: Relax assert a little to fix flake on regress-3976 (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Relax assert a little to fix flake on regress-3976 R=verwaest@chromium.org NOTRY=true BUG= Committed: https://crrev.com/b20edd7772892ff8b2b280b35e521fbc2cc4a5f6 Cr-Commit-Position: refs/heads/master@{#27515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Erik Corry Chromium.org
5 years, 8 months ago (2015-03-30 10:23:42 UTC) #1
Toon Verwaest
lgtm
5 years, 8 months ago (2015-03-30 10:24:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045763002/1
5 years, 8 months ago (2015-03-30 10:25:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045763002/1
5 years, 8 months ago (2015-03-30 10:37:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 10:37:33 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b20edd7772892ff8b2b280b35e521fbc2cc4a5f6 Cr-Commit-Position: refs/heads/master@{#27515}
5 years, 8 months ago (2015-03-30 10:37:43 UTC) #9
Erik Corry Chromium.org
5 years, 8 months ago (2015-04-01 09:20:29 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1050033003/ by erikcorry@chromium.org.

The reason for reverting is: Reverting due to JSOn parser failures.

Powered by Google App Engine
This is Rietveld 408576698