Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: test/cctest/test-cpu-profiler.cc

Issue 1045753002: CpuProfiler: public API for deopt info in cpu profiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: size_t Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/v8-profiler.h ('K') | « src/profile-generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc
index a8cbdd505cfe0626de7669c6d952a5cccd8dca52..229dff08e90467563bbd9ed29d6c154aa8916679 100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -56,8 +56,8 @@ static v8::Local<v8::Function> GetFunction(v8::Context* env, const char* name) {
}
-static int offset(const char* src, const char* substring) {
- return static_cast<int>(strstr(src, substring) - src);
+static unsigned int offset(const char* src, const char* substring) {
alph 2015/03/30 12:31:21 could you please add a check that strstr is not nu
loislo 2015/03/30 13:04:22 done
+ return static_cast<unsigned int>(strstr(src, substring) - src);
}
« include/v8-profiler.h ('K') | « src/profile-generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698