Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/profile-generator.h

Issue 1045753002: CpuProfiler: public API for deopt info in cpu profiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: unnecessary typedef was removed Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index e013e29c5db77a1e9852c5a9ef691f789cb96e77..1ce19409069af802a72a2bc7d6ac185b8bbcfa35 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -37,16 +37,6 @@ class JITLineInfoTable : public Malloced {
};
-struct DeoptInfo {
- const char* deopt_reason;
- struct Frame {
- int script_id;
- int position;
- };
- std::vector<Frame> stack;
-};
-
-
class CodeEntry {
public:
// CodeEntry doesn't own name strings, just references them.
@@ -83,7 +73,7 @@ class CodeEntry {
deopt_position_ = position;
pc_offset_ = pc_offset;
}
- DeoptInfo GetDeoptInfo();
+ CpuProfileDeoptInfo GetDeoptInfo();
const char* deopt_reason() const { return deopt_reason_; }
SourcePosition deopt_position() const { return deopt_position_; }
bool has_deopt_info() const { return !deopt_position_.IsUnknown(); }
@@ -173,7 +163,9 @@ class ProfileNode {
bool GetLineTicks(v8::CpuProfileNode::LineTick* entries,
unsigned int length) const;
void CollectDeoptInfo(CodeEntry* entry);
- const std::vector<DeoptInfo>& deopt_infos() const { return deopt_infos_; }
+ const std::vector<CpuProfileDeoptInfo>& deopt_infos() const {
+ return deopt_infos_;
+ }
void Print(int indent);
@@ -196,7 +188,7 @@ class ProfileNode {
unsigned id_;
HashMap line_ticks_;
- std::vector<DeoptInfo> deopt_infos_;
+ std::vector<CpuProfileDeoptInfo> deopt_infos_;
DISALLOW_COPY_AND_ASSIGN(ProfileNode);
};
« no previous file with comments | « src/api.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698