ui/views/controls/combobox/combobox.cc - Issue 104573003: Make ComboboxListener work around being deleted from OnSelectedIndexChanged().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 104573003: Make ComboboxListener work around being deleted from OnSelectedIndexChanged(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: , Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/combobox/combobox.cc

diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc

index d726fe2032f5528c0a56925f9378ff27d2de58a9..bcf19aef10c06d6a5d77184f2bb5059d31b4fd9f 100644

--- a/ui/views/controls/combobox/combobox.cc

+++ b/ui/views/controls/combobox/combobox.cc

@@ -468,10 +468,10 @@ void Combobox::ShowDropDownMenu(ui::MenuSourceType source_type) {

}

void Combobox::OnSelectionChanged() {

- if (listener_)

- listener_->OnSelectedIndexChanged(this);

NotifyAccessibilityEvent(ui::AccessibilityTypes::EVENT_VALUE_CHANGED, false);

SchedulePaint();

+ if (listener_)

+ listener_->OnSelectedIndexChanged(this);

}

sky 2013/12/05 04:07:30 Add a comment here that this may be deleted.

Dan Beam 2013/12/05 17:05:33 Done.

int Combobox::MenuCommandToIndex(int menu_command_id) const {

« no previous file with comments | « no previous file | ui/views/controls/combobox/combobox_unittest.cc » ('j') | ui/views/controls/combobox/combobox_unittest.cc » ('J')