Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 104573003: Make ComboboxListener work around being deleted from OnSelectedIndexChanged(). (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Make ComboboxListener work around being deleted from OnSelectedIndexChanged(). The concrete case for this is that the requestAutocomplete() dialog is adding a country switcher that rebuilds (and deletes) its inputs on country change. BUG=317837 R=sky@chromium.org TEST=views_unittests, no segfaults Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239098

Patch Set 1 : , #

Total comments: 4

Patch Set 2 : sky@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -7 lines) Patch
M ui/views/controls/combobox/combobox.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/combobox/combobox_unittest.cc View 1 4 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Beam
7 years ago (2013-12-05 02:06:05 UTC) #1
sky
LGTM https://codereview.chromium.org/104573003/diff/20001/ui/views/controls/combobox/combobox.cc File ui/views/controls/combobox/combobox.cc (right): https://codereview.chromium.org/104573003/diff/20001/ui/views/controls/combobox/combobox.cc#newcode475 ui/views/controls/combobox/combobox.cc:475: } Add a comment here that this may ...
7 years ago (2013-12-05 04:07:30 UTC) #2
Dan Beam
https://codereview.chromium.org/104573003/diff/20001/ui/views/controls/combobox/combobox.cc File ui/views/controls/combobox/combobox.cc (right): https://codereview.chromium.org/104573003/diff/20001/ui/views/controls/combobox/combobox.cc#newcode475 ui/views/controls/combobox/combobox.cc:475: } On 2013/12/05 04:07:30, sky wrote: > Add a ...
7 years ago (2013-12-05 17:05:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/104573003/80001
7 years ago (2013-12-05 17:06:20 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-06 01:50:56 UTC) #5
Message was sent while issue was closed.
Change committed as 239098

Powered by Google App Engine
This is Rietveld 408576698