Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1045703003: [turbofan] Keep AstGraphBuilder context chain length in sync. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Keep AstGraphBuilder context chain length in sync. This keeps the length of the context chain tracked by the environment in sync even for local control flow commands. It removes the need to guess the correct chain length at Environment::Merge points. R=titzer@chromium.org Committed: https://crrev.com/9596b36c1df3764daa07ca1afbbd1790389b0037 Cr-Commit-Position: refs/heads/master@{#27588}

Patch Set 1 #

Patch Set 2 : Follow-up fix. #

Total comments: 4

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 4 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 9 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 8 months ago (2015-03-31 15:22:43 UTC) #1
titzer
LGTM other than naming suggestions. https://codereview.chromium.org/1045703003/diff/20001/src/compiler/ast-graph-builder.h File src/compiler/ast-graph-builder.h (right): https://codereview.chromium.org/1045703003/diff/20001/src/compiler/ast-graph-builder.h#newcode402 src/compiler/ast-graph-builder.h:402: void TrimContext(int trim_to_length) { ...
5 years, 8 months ago (2015-04-02 11:03:28 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1045703003/diff/20001/src/compiler/ast-graph-builder.h File src/compiler/ast-graph-builder.h (right): https://codereview.chromium.org/1045703003/diff/20001/src/compiler/ast-graph-builder.h#newcode402 src/compiler/ast-graph-builder.h:402: void TrimContext(int trim_to_length) { contexts()->resize(trim_to_length); } On 2015/04/02 11:03:28, ...
5 years, 8 months ago (2015-04-02 11:29:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045703003/40001
5 years, 8 months ago (2015-04-02 11:38:26 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-02 11:49:11 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 11:49:18 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9596b36c1df3764daa07ca1afbbd1790389b0037
Cr-Commit-Position: refs/heads/master@{#27588}

Powered by Google App Engine
This is Rietveld 408576698