Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1045693002: Expose multiline attribute from blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reland Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.cpp ('k') | Source/modules/accessibility/AXObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXNodeObject.cpp
diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp
index 5ef595aae944a39c2bb630b694d3945aafe35bd2..5f34fd13931091e44b4f231ea4db6d2e4983393f 100644
--- a/Source/modules/accessibility/AXNodeObject.cpp
+++ b/Source/modules/accessibility/AXNodeObject.cpp
@@ -333,7 +333,7 @@ AccessibilityRole AXNodeObject::determineAccessibilityRoleUtil()
return selectElement.multiple() ? ListBoxRole : PopUpButtonRole;
}
if (isHTMLTextAreaElement(*node()))
- return TextAreaRole;
+ return TextFieldRole;
if (headingLevel())
return HeadingRole;
if (isHTMLDivElement(*node()))
@@ -400,9 +400,6 @@ AccessibilityRole AXNodeObject::determineAriaRoleAttribute() const
if (role == ButtonRole)
role = buttonRoleType();
- if (role == TextAreaRole && !ariaIsMultiline())
- role = TextFieldRole;
-
role = remapAriaRoleDueToParent(role);
if (role)
@@ -757,7 +754,7 @@ bool AXNodeObject::isPasswordField() const
return false;
AccessibilityRole ariaRole = ariaRoleAttribute();
- if (ariaRole != TextFieldRole && ariaRole != TextAreaRole && ariaRole != UnknownRole)
+ if (ariaRole != TextFieldRole && ariaRole != UnknownRole)
return false;
return toHTMLInputElement(node)->type() == InputTypeNames::password;
@@ -1047,7 +1044,7 @@ unsigned AXNodeObject::hierarchicalLevel() const
String AXNodeObject::ariaAutoComplete() const
{
- if (roleValue() != ComboBoxRole && roleValue() != TextAreaRole)
+ if (roleValue() != ComboBoxRole)
return String();
const AtomicString& ariaAutoComplete = getAttribute(aria_autocompleteAttr).lower();
« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.cpp ('k') | Source/modules/accessibility/AXObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698