Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1045663002: Cancel scans when directory changed. (Closed)

Created:
5 years, 8 months ago by Steve McKay
Modified:
5 years, 8 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cancel scans when directory changed. TEST=*ImportController* and *MediaScanner* Committed: https://crrev.com/e5f44076cdabe3ac559b3db266a30f1462baeca1 Cr-Commit-Position: refs/heads/master@{#323184}

Patch Set 1 #

Patch Set 2 : Cancel scan jobs when directory changes. #

Patch Set 3 : Ensure we don't create directory scan for a spurios (empty) selection event. #

Patch Set 4 : Also, cancel scans when window closes...and add test coverage. #

Total comments: 28

Patch Set 5 : Respond to review comments. #

Total comments: 6

Patch Set 6 : Respond to review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -134 lines) Patch
M ui/file_manager/file_manager/background/js/media_scanner.js View 1 2 3 4 5 14 chunks +56 lines, -21 lines 0 comments Download
M ui/file_manager/file_manager/background/js/mock_media_scanner.js View 1 2 3 4 5 5 chunks +31 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/common/js/importer_common.js View 1 2 chunks +3 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 2 3 4 16 chunks +103 lines, -64 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller_unittest.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller_unittest.js View 1 2 3 4 12 chunks +127 lines, -42 lines 0 comments Download

Messages

Total messages: 18 (3 generated)
Steve McKay
Cancel scan jobs when directory changes.
5 years, 8 months ago (2015-03-31 06:43:13 UTC) #1
Steve McKay
Ensure we don't create directory scan for a spurios (empty) selection event.
5 years, 8 months ago (2015-03-31 09:24:06 UTC) #2
Steve McKay
Cancel scans when windows close also...and add test coverage.
5 years, 8 months ago (2015-04-01 00:58:22 UTC) #4
Steve McKay
Ready for review.
5 years, 8 months ago (2015-04-01 01:00:12 UTC) #5
mtomasz
First scan. Looking in depth into scan_controller.js now. https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/background/js/media_scanner.js File ui/file_manager/file_manager/background/js/media_scanner.js (right): https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/background/js/media_scanner.js#newcode106 ui/file_manager/file_manager/background/js/media_scanner.js:106: console.log(scan.name ...
5 years, 8 months ago (2015-04-01 02:28:45 UTC) #6
mtomasz
I'll do one more scan. https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/foreground/js/import_controller.js File ui/file_manager/file_manager/foreground/js/import_controller.js (right): https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/foreground/js/import_controller.js#newcode236 ui/file_manager/file_manager/foreground/js/import_controller.js:236: importer.ImportController.prototype.onScanCanceled_ = function(scan) { ...
5 years, 8 months ago (2015-04-01 02:31:09 UTC) #7
mtomasz
https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/foreground/js/import_controller.js File ui/file_manager/file_manager/foreground/js/import_controller.js (right): https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/foreground/js/import_controller.js#newcode1120 ui/file_manager/file_manager/foreground/js/import_controller.js:1120: window.addEventListener('pagehide', listener); nit: indent https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/foreground/js/import_controller_unittest.js File ui/file_manager/file_manager/foreground/js/import_controller_unittest.js (right): https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/foreground/js/import_controller_unittest.js#newcode155 ...
5 years, 8 months ago (2015-04-01 03:19:48 UTC) #8
Steve McKay
Respond to review comments.
5 years, 8 months ago (2015-04-01 03:52:37 UTC) #9
Steve McKay
PTAL (hit commit box if you can). https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/background/js/media_scanner.js File ui/file_manager/file_manager/background/js/media_scanner.js (right): https://codereview.chromium.org/1045663002/diff/60001/ui/file_manager/file_manager/background/js/media_scanner.js#newcode106 ui/file_manager/file_manager/background/js/media_scanner.js:106: console.log(scan.name + ...
5 years, 8 months ago (2015-04-01 03:52:53 UTC) #10
mtomasz
lgtm with tiny nits https://codereview.chromium.org/1045663002/diff/80001/ui/file_manager/file_manager/background/js/media_scanner.js File ui/file_manager/file_manager/background/js/media_scanner.js (right): https://codereview.chromium.org/1045663002/diff/80001/ui/file_manager/file_manager/background/js/media_scanner.js#newcode194 ui/file_manager/file_manager/background/js/media_scanner.js:194: var end = begin + ...
5 years, 8 months ago (2015-04-01 03:55:40 UTC) #11
Steve McKay
Respond to review comments.
5 years, 8 months ago (2015-04-01 04:00:06 UTC) #12
Steve McKay
Dones. https://codereview.chromium.org/1045663002/diff/80001/ui/file_manager/file_manager/background/js/media_scanner.js File ui/file_manager/file_manager/background/js/media_scanner.js (right): https://codereview.chromium.org/1045663002/diff/80001/ui/file_manager/file_manager/background/js/media_scanner.js#newcode194 ui/file_manager/file_manager/background/js/media_scanner.js:194: var end = begin + importer.DefaultMediaScanner.SCAN_BATCH_SIZE ; On ...
5 years, 8 months ago (2015-04-01 04:00:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045663002/100001
5 years, 8 months ago (2015-04-01 04:00:31 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-01 04:33:25 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 04:34:28 UTC) #18
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/e5f44076cdabe3ac559b3db266a30f1462baeca1
Cr-Commit-Position: refs/heads/master@{#323184}

Powered by Google App Engine
This is Rietveld 408576698