Remove LOAD_IS_DOWNLOAD network load flag.

Remove LOAD_IS_DOWNLOAD network load flag.

As of https://codereview.chromium.org/1008873006 it no longer does
anything.

BUG=426442, 318217
Committed: https://crrev.com/3cb1d73d7667f59cc769a5f40da219152b8dd236
Cr-Commit-Position: refs/heads/master@{#325533}

[mmenke, 2015-04-13 19:20:12]

mmenke@chromium.org changed reviewers:
+ rdsmith@chromium.org

[mmenke, 2015-04-13 19:20:13]

No rush on this, just isn't currently being used anywhere, and I'd like to
remove it before someone else decides it's a good idea to start depending on it.

[Randy Smith (Not in Mondays), 2015-04-13 22:41:31]

LGTM, with two issues raised that I don't think are problems, but that you'd
know more about than I:

* I presume that this won't cause any problems for net-internals with a
generate/view version pair straddling the change (which I think means that I
presume each net-internals dump stores its own net error code <-> text
translation table).

* I presume this won't cause any problems for any already written chrome
extensions (I looked, and couldn't find a general "network" extensions API, nor
anyplace where the load flags list was used to generate JS equivalents, so I
don't believe so).

[mmenke, 2015-04-13 22:45:43]

On 2015/04/13 22:41:31, rdsmith wrote:
> LGTM, with two issues raised that I don't think are problems, but that you'd
> know more about than I:
> 
> * I presume that this won't cause any problems for net-internals with a
> generate/view version pair straddling the change (which I think means that I
> presume each net-internals dump stores its own net error code <-> text
> translation table).

net-internals can handle it, and will correctly display older logs (And older
versions will display newer ones).

> * I presume this won't cause any problems for any already written chrome
> extensions (I looked, and couldn't find a general "network" extensions API,
nor
> anyplace where the load flags list was used to generate JS equivalents, so I
> don't believe so).

I don't believe there are any issues here.  If we're exposing load flags to
extensions, that's a bug.

Thanks for the review!

[mmenke, 2015-04-14 16:50:08]

mmenke@chromium.org changed reviewers:
+ treib@chromium.org

[mmenke, 2015-04-14 16:50:09]

[+treib]:  Please review
chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc
[+bartfab]:  Please review
components/policy/core/common/cloud/external_policy_data_fetcher.cc

This flag no longer does anything, so we're removing it.  It was only used to
figure out whether we should leave downloads gzipped when incorrectly using
content-encoding headers.

[mmenke, 2015-04-14 21:01:43]

mmenke@chromium.org changed reviewers:
+ bartfab@chromium.org

[mmenke, 2015-04-14 21:01:43]

[+bartfab (for real, this time)]:  Please review
components/policy/core/common/cloud/external_policy_data_fetcher.cc

This flag no longer does anything, so we're removing it.  It was only used to
figure out whether we should leave downloads gzipped when incorrectly using
content-encoding headers.

[Marc Treib, 2015-04-15 09:48:42]

supervised_user LGTM

[bartfab (slow), 2015-04-16 16:04:44]

lgtm

[mmenke, 2015-04-16 16:08:57]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2015-04-16 16:09:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1045593002/20001

[commit-bot: I haz the power, 2015-04-16 18:59:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 18:59:52]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mmenke, 2015-04-16 19:06:59]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2015-04-16 19:09:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1045593002/20001

[mmenke, 2015-04-16 20:10:42]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2015-04-16 20:17:00]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2015-04-16 20:18:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1045593002/20001

[mmenke, 2015-04-16 21:40:04]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2015-04-16 21:40:12]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2015-04-16 21:40:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1045593002/20001

[commit-bot: I haz the power, 2015-04-16 22:57:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-16 22:58:35]

Patchset 2 (id:??) landed as
https://crrev.com/3cb1d73d7667f59cc769a5f40da219152b8dd236
Cr-Commit-Position: refs/heads/master@{#325533}