Issue 1045533002: pkg/string_scanner: code format, expanded dependency constraint on unittest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1045533002: pkg/string_scanner: code format, expanded dependency constraint on unittest (Closed)

Created:
5 years, 8 months ago by kevmoo

Modified:
5 years, 8 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/string_scanner.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

code format, expanded dependency constraint on unittest, removed unused variable fixed homepage URL R=nweiz@google.com Committed: https://github.com/dart-lang/string_scanner/commit/9f00056b32f41efc376adecfb696a01bc7c593d7

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -19 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/line_scanner.dart	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	lib/src/string_scanner.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/src/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pubspec.yaml	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/error_test.dart	View	4 chunks	+9 lines, -6 lines	0 comments	Download
M	test/string_scanner_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

kevmoo

5 years, 8 months ago (2015-03-30 22:20:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9f00056b32f41efc376adecfb696a01bc7c593d7 (presubmit successful).