Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1045493002: use Sk4f for matrix math (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 8 months ago
Reviewers:
mtklein, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use Sk4f for matrix math Need to land SK_SUPPORT_LEGACY_SCALAR_MAPPOINTS in chrome to suppress Affine version which causes slight differences (which will need to be rebaselined) BUG=skia: Committed: https://skia.googlesource.com/skia/+/7da19014fda527a52381d85cc50b951031fa4754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -195 lines) Patch
M bench/MatrixBench.cpp View 2 chunks +8 lines, -17 lines 0 comments Download
M include/core/SkMatrix.h View 3 chunks +6 lines, -8 lines 0 comments Download
M src/core/SkMatrix.cpp View 4 chunks +60 lines, -126 lines 0 comments Download
M tests/MatrixTest.cpp View 2 chunks +0 lines, -44 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045493002/1
5 years, 9 months ago (2015-03-28 02:01:56 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-28 02:01:57 UTC) #3
reed2
SK_SUPPORT_LEGACY_SCALAR_MAPPOINTS needed in chrome (or Affine_vpts will cause slight image diffs). Those diffs should be ...
5 years, 9 months ago (2015-03-28 02:02:58 UTC) #5
mtklein
lgtm
5 years, 9 months ago (2015-03-28 03:05:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045493002/1
5 years, 8 months ago (2015-03-29 18:51:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045493002/1
5 years, 8 months ago (2015-03-29 18:52:34 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-03-29 18:58:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7da19014fda527a52381d85cc50b951031fa4754

Powered by Google App Engine
This is Rietveld 408576698