Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: base/chromeos/memory_pressure_monitor_chromeos_unittest.cc

Issue 1045433002: Migrate ChromeOS to base::MemoryPressureMonitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/chromeos/memory_pressure_observer_chromeos.h" 6 #include "base/chromeos/memory_pressure_monitor_chromeos.h"
7 #include "base/memory/memory_pressure_listener.h" 7 #include "base/memory/memory_pressure_listener.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace base { 11 namespace base {
12 12
13 namespace { 13 namespace {
14 14
15 // True if the memory notifier got called. 15 // True if the memory notifier got called.
16 // Do not read/modify value directly. 16 // Do not read/modify value directly.
(...skipping 16 matching lines...) Expand all
33 33
34 // Returns true when OnMemoryPressure was called (and resets it). 34 // Returns true when OnMemoryPressure was called (and resets it).
35 bool WasOnMemoryPressureCalled() { 35 bool WasOnMemoryPressureCalled() {
36 bool b = on_memory_pressure_called; 36 bool b = on_memory_pressure_called;
37 ResetOnMemoryPressureCalled(); 37 ResetOnMemoryPressureCalled();
38 return b; 38 return b;
39 } 39 }
40 40
41 } // namespace 41 } // namespace
42 42
43 class TestMemoryPressureObserver : public MemoryPressureObserverChromeOS { 43 class TestMemoryPressureMonitor : public MemoryPressureMonitorChromeOS {
44 public: 44 public:
45 TestMemoryPressureObserver() : 45 TestMemoryPressureMonitor() :
46 MemoryPressureObserverChromeOS( 46 MemoryPressureMonitorChromeOS(
47 MemoryPressureObserverChromeOS::THRESHOLD_DEFAULT), 47 MemoryPressureMonitorChromeOS::THRESHOLD_DEFAULT),
48 memory_in_percent_override_(0) { 48 memory_in_percent_override_(0) {
49 // Disable any timers which are going on and set a special memory reporting 49 // Disable any timers which are going on and set a special memory reporting
50 // function. 50 // function.
51 StopObserving(); 51 StopObserving();
52 } 52 }
53 ~TestMemoryPressureObserver() override {} 53 ~TestMemoryPressureMonitor() override {}
54 54
55 void SetMemoryInPercentOverride(int percent) { 55 void SetMemoryInPercentOverride(int percent) {
56 memory_in_percent_override_ = percent; 56 memory_in_percent_override_ = percent;
57 } 57 }
58 58
59 void CheckMemoryPressureForTest() { 59 void CheckMemoryPressureForTest() {
60 CheckMemoryPressure(); 60 CheckMemoryPressure();
61 } 61 }
62 62
63 private: 63 private:
64 int GetUsedMemoryInPercent() override { 64 int GetUsedMemoryInPercent() override {
65 return memory_in_percent_override_; 65 return memory_in_percent_override_;
66 } 66 }
67 67
68 int memory_in_percent_override_; 68 int memory_in_percent_override_;
69 DISALLOW_COPY_AND_ASSIGN(TestMemoryPressureObserver); 69 DISALLOW_COPY_AND_ASSIGN(TestMemoryPressureMonitor);
70 }; 70 };
71 71
72 // This test tests the various transition states from memory pressure, looking 72 // This test tests the various transition states from memory pressure, looking
73 // for the correct behavior on event reposting as well as state updates. 73 // for the correct behavior on event reposting as well as state updates.
74 TEST(MemoryPressureObserverChromeOSTest, CheckMemoryPressure) { 74 TEST(MemoryPressureMonitorChromeOSTest, CheckMemoryPressure) {
75 base::MessageLoopForUI message_loop; 75 base::MessageLoopForUI message_loop;
76 scoped_ptr<TestMemoryPressureObserver> observer( 76 scoped_ptr<TestMemoryPressureMonitor> monitor(
77 new TestMemoryPressureObserver); 77 new TestMemoryPressureMonitor);
78 scoped_ptr<MemoryPressureListener> listener( 78 scoped_ptr<MemoryPressureListener> listener(
79 new MemoryPressureListener(base::Bind(&OnMemoryPressure))); 79 new MemoryPressureListener(base::Bind(&OnMemoryPressure)));
80 // Checking the memory pressure while 0% are used should not produce any 80 // Checking the memory pressure while 0% are used should not produce any
81 // events. 81 // events.
82 observer->SetMemoryInPercentOverride(0); 82 monitor->SetMemoryInPercentOverride(0);
83 ResetOnMemoryPressureCalled(); 83 ResetOnMemoryPressureCalled();
84 84
85 observer->CheckMemoryPressureForTest(); 85 monitor->CheckMemoryPressureForTest();
86 message_loop.RunUntilIdle(); 86 message_loop.RunUntilIdle();
87 EXPECT_FALSE(WasOnMemoryPressureCalled()); 87 EXPECT_FALSE(WasOnMemoryPressureCalled());
88 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE, 88 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE,
89 observer->GetCurrentPressureLevel()); 89 monitor->GetCurrentPressureLevel());
90 90
91 // Setting the memory level to 80% should produce a moderate pressure level. 91 // Setting the memory level to 80% should produce a moderate pressure level.
92 observer->SetMemoryInPercentOverride(80); 92 monitor->SetMemoryInPercentOverride(80);
93 observer->CheckMemoryPressureForTest(); 93 monitor->CheckMemoryPressureForTest();
94 message_loop.RunUntilIdle(); 94 message_loop.RunUntilIdle();
95 EXPECT_TRUE(WasOnMemoryPressureCalled()); 95 EXPECT_TRUE(WasOnMemoryPressureCalled());
96 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE, 96 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE,
97 observer->GetCurrentPressureLevel()); 97 monitor->GetCurrentPressureLevel());
98 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE, 98 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE,
99 on_memory_pressure_level); 99 on_memory_pressure_level);
100 100
101 // We need to check that the event gets reposted after a while. 101 // We need to check that the event gets reposted after a while.
102 int i = 0; 102 int i = 0;
103 for (; i < 100; i++) { 103 for (; i < 100; i++) {
104 observer->CheckMemoryPressureForTest(); 104 monitor->CheckMemoryPressureForTest();
105 message_loop.RunUntilIdle(); 105 message_loop.RunUntilIdle();
106 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE, 106 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE,
107 observer->GetCurrentPressureLevel()); 107 monitor->GetCurrentPressureLevel());
108 if (WasOnMemoryPressureCalled()) { 108 if (WasOnMemoryPressureCalled()) {
109 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE, 109 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE,
110 on_memory_pressure_level); 110 on_memory_pressure_level);
111 break; 111 break;
112 } 112 }
113 } 113 }
114 // Should be more then 5 and less then 100. 114 // Should be more then 5 and less then 100.
115 EXPECT_LE(5, i); 115 EXPECT_LE(5, i);
116 EXPECT_GE(99, i); 116 EXPECT_GE(99, i);
117 117
118 // Setting the memory usage to 99% should produce critical levels. 118 // Setting the memory usage to 99% should produce critical levels.
119 observer->SetMemoryInPercentOverride(99); 119 monitor->SetMemoryInPercentOverride(99);
120 observer->CheckMemoryPressureForTest(); 120 monitor->CheckMemoryPressureForTest();
121 message_loop.RunUntilIdle(); 121 message_loop.RunUntilIdle();
122 EXPECT_TRUE(WasOnMemoryPressureCalled()); 122 EXPECT_TRUE(WasOnMemoryPressureCalled());
123 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL, 123 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL,
124 on_memory_pressure_level); 124 on_memory_pressure_level);
125 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL, 125 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL,
126 observer->GetCurrentPressureLevel()); 126 monitor->GetCurrentPressureLevel());
127 127
128 // Calling it again should immediately produce a second call. 128 // Calling it again should immediately produce a second call.
129 observer->CheckMemoryPressureForTest(); 129 monitor->CheckMemoryPressureForTest();
130 message_loop.RunUntilIdle(); 130 message_loop.RunUntilIdle();
131 EXPECT_TRUE(WasOnMemoryPressureCalled()); 131 EXPECT_TRUE(WasOnMemoryPressureCalled());
132 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL, 132 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL,
133 on_memory_pressure_level); 133 on_memory_pressure_level);
134 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL, 134 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL,
135 observer->GetCurrentPressureLevel()); 135 monitor->GetCurrentPressureLevel());
136 136
137 // When lowering the pressure again we should not get an event, but the 137 // When lowering the pressure again we should not get an event, but the
138 // pressure should go back to moderate. 138 // pressure should go back to moderate.
139 observer->SetMemoryInPercentOverride(80); 139 monitor->SetMemoryInPercentOverride(80);
140 observer->CheckMemoryPressureForTest(); 140 monitor->CheckMemoryPressureForTest();
141 message_loop.RunUntilIdle(); 141 message_loop.RunUntilIdle();
142 EXPECT_FALSE(WasOnMemoryPressureCalled()); 142 EXPECT_FALSE(WasOnMemoryPressureCalled());
143 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE, 143 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE,
144 observer->GetCurrentPressureLevel()); 144 monitor->GetCurrentPressureLevel());
145 145
146 // We should need exactly the same amount of calls as before, before the next 146 // We should need exactly the same amount of calls as before, before the next
147 // call comes in. 147 // call comes in.
148 int j = 0; 148 int j = 0;
149 for (; j < 100; j++) { 149 for (; j < 100; j++) {
150 observer->CheckMemoryPressureForTest(); 150 monitor->CheckMemoryPressureForTest();
151 message_loop.RunUntilIdle(); 151 message_loop.RunUntilIdle();
152 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE, 152 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE,
153 observer->GetCurrentPressureLevel()); 153 monitor->GetCurrentPressureLevel());
154 if (WasOnMemoryPressureCalled()) { 154 if (WasOnMemoryPressureCalled()) {
155 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE, 155 EXPECT_EQ(MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE,
156 on_memory_pressure_level); 156 on_memory_pressure_level);
157 break; 157 break;
158 } 158 }
159 } 159 }
160 // We should have needed exactly the same amount of checks as before. 160 // We should have needed exactly the same amount of checks as before.
161 EXPECT_EQ(j, i); 161 EXPECT_EQ(j, i);
162 } 162 }
163 163
164 } // namespace base 164 } // namespace base
OLDNEW
« no previous file with comments | « base/chromeos/memory_pressure_monitor_chromeos.cc ('k') | base/chromeos/memory_pressure_observer_chromeos.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698