Histograms - Support histograms for Plugins, GPU

chrome/renderer/page_load_histograms.cc

Index: chrome/renderer/page_load_histograms.cc
===================================================================
--- chrome/renderer/page_load_histograms.cc	(revision 139790)
+++ chrome/renderer/page_load_histograms.cc	(working copy)
@@ -7,12 +7,12 @@
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
+#include "base/metrics/histogram_sender.h"
 #include "base/time.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/extensions/url_pattern.h"
 #include "chrome/renderer/chrome_content_renderer_client.h"
 #include "chrome/renderer/prerender/prerender_helper.h"
-#include "chrome/renderer/renderer_histogram_snapshots.h"
 #include "content/public/renderer/document_state.h"
 #include "content/public/renderer/render_view.h"
 #include "googleurl/src/gurl.h"
@@ -120,11 +120,11 @@
 
 PageLoadHistograms::PageLoadHistograms(
     content::RenderView* render_view,
-    RendererHistogramSnapshots* histogram_snapshots)
+    base::HistogramSender* histogram_sender)
     : content::RenderViewObserver(render_view),
       cross_origin_access_count_(0),
       same_origin_access_count_(0),
-      histogram_snapshots_(histogram_snapshots) {
+      histogram_sender_(histogram_sender) {
 }
 
 void PageLoadHistograms::Dump(WebFrame* frame) {
@@ -942,7 +942,7 @@
   // TODO(jar) BUG=33233: This needs to be moved to a PostDelayedTask, and it
   // should post when the onload is complete, so that it doesn't interfere with
   // the next load.
-  histogram_snapshots_->SendHistograms(
+  histogram_sender_->SendHistograms(

[jam, 2012/06/01 18:23:23]

it is a little strange that this class gets a pointer to histogram_sender_ which
has an implementation, only so that it can use the pure virtual function. i.e.
since it doesn't use any of the implementation in it, it seems all it needs is
just a way to tell the histogram code in the child process to send histograms
(i.e. RenderThread::UpdateHistograms()).

[ramant (doing other things), 2012/06/07 02:04:41]

Done.

       chrome::kHistogramSynchronizerReservedSequenceNumber);
 }