Issue 1045363004: ServiceWorker: Clean up clients-matchall-client-types.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1045363004: ServiceWorker: Clean up clients-matchall-client-types.html (Closed)

Created:
5 years, 8 months ago by nhiroki

Modified:
5 years, 8 months ago

Reviewers:
falken

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

ServiceWorker: Clean up clients-matchall-client-types.html This is a follow-up CL for https://codereview.chromium.org/1040993003/ BUG=460415 TEST=http/tests/serviceworker/clients-matchall-client-types.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192937

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -22 lines)			Patch
M	LayoutTests/http/tests/serviceworker/clients-matchall-client-types.html	View	3 chunks	+14 lines, -18 lines	0 comments	Download
A +	LayoutTests/http/tests/serviceworker/resources/clients-matchall-client-types-shared-worker.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	LayoutTests/http/tests/serviceworker/resources/clients-matchall-client-types-worker.js	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/modules/serviceworkers/ServiceWorkerClients.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045363004/1

5 years, 8 months ago (2015-04-01 11:30:15 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-01 14:03:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192937

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages