Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 1045343002: Split normalized reading from non-normalized in SVGPathParser (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Split normalized reading from non-normalized in SVGPathParser Move to parseAndNormalizePath() and parsePath() respectively and move state to the corresponding one as appropriate. Default inline parsePathDataFromSource. Since callsite usually pass a constant PathParsingMode and checkForInitialMoveTo, this allows for some specialization. BUG=467592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192901

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -31 lines) Patch
M Source/core/svg/SVGPathParser.h View 1 chunk +12 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathParser.cpp View 3 chunks +38 lines, -30 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 8 months ago (2015-03-31 18:43:28 UTC) #2
f(malita)
lgtm https://codereview.chromium.org/1045343002/diff/1/Source/core/svg/SVGPathParser.cpp File Source/core/svg/SVGPathParser.cpp (right): https://codereview.chromium.org/1045343002/diff/1/Source/core/svg/SVGPathParser.cpp#newcode333 Source/core/svg/SVGPathParser.cpp:333: bool SVGPathParser::parseAndNormalizePath() These two are quite similar - ...
5 years, 8 months ago (2015-04-01 03:59:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045343002/1
5 years, 8 months ago (2015-04-01 03:59:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192901
5 years, 8 months ago (2015-04-01 04:03:40 UTC) #6
fs
5 years, 8 months ago (2015-04-01 08:55:29 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1045343002/diff/1/Source/core/svg/SVGPathPars...
File Source/core/svg/SVGPathParser.cpp (right):

https://codereview.chromium.org/1045343002/diff/1/Source/core/svg/SVGPathPars...
Source/core/svg/SVGPathParser.cpp:333: bool
SVGPathParser::parseAndNormalizePath()
On 2015/04/01 03:59:21, f(malita) wrote:
> These two are quite similar - would it be feasible to consolidate as a
function
> template (with a consumer arg) at some point?

Yes, I hope to get to that point eventually. Haven't quite made up my mind on
whether it's better to let consumers do normalization explicitly (aggregating
the NormalizingConsumer) or leave it to the caller - or both =). Leaning towards
the latter ATM, (early) opinions welcome.

Powered by Google App Engine
This is Rietveld 408576698