Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1045323002: emit interfaces before use (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/typed_data.js ('k') | lib/src/js/printer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 5b016e261e5736e163d1242dd1862015d4007672..b89179016912e926b45b8ad6cef56fa4ba80aa8e 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -372,6 +372,9 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
for (var m in classElem.mixins) {
_emitClassIfNeeded(classDefs, m.element);
}
+ for (var i in classElem.interfaces) {
+ _emitClassIfNeeded(classDefs, i.element);
+ }
classDefs.add(body);
return _statement(classDefs);
}
@@ -398,6 +401,10 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
if (result) break;
result = _classMightNotBeLoaded(mixin.element);
}
+ for (var iface in cls.interfaces) {
+ if (result) break;
+ result = _classMightNotBeLoaded(iface.element);
+ }
return _lazyClassMemo[cls] = result;
}
« no previous file with comments | « lib/runtime/dart/typed_data.js ('k') | lib/src/js/printer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698